Fix duplicate testonly kwargs in test.bzl #609
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerrymarino
approved these changes
Nov 18, 2022
Contributor
jerrymarino
left a comment
jerrymarino
left a comment
There was a problem hiding this comment.
@luispadron LGTM overall and something we'd want even if we work towards other improvements / back port injecting the missing XCTest paths automatically
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If a user were to pass
testonlyto aios_unit_testtarget then it fails with duplicate kwargs error due totestonly = Truebeing hardcoded in the rules.This updates the rules to default to
truefortestonlyfile removing thetestonlyarg from kwargs to resolve the duplicate kwargs error.Related change: bazel-ios/cocoapods-bazel#82