Skip to content

Add testonly to libraries that link XCTest #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dierksen merged 5 commits into from
Nov 18, 2022
Merged

Add testonly to libraries that link XCTest #82

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b9ba793
Add testonly to libraries that link XCTest
dierksen Nov 18, 2022
171256e
also for weak_sdk_frameworks
dierksen Nov 18, 2022
2f7a8b8
fix bad syntax
dierksen Nov 18, 2022
e7ec678
bump .bazelversion to match rules_ios
dierksen Nov 18, 2022
1f1b458
rubocop fixes
dierksen Nov 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions lib/cocoapods/bazel/target.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -376,6 +376,9 @@ def to_rule_kwargs
kwargs[:sdk_frameworks] = file_accessors.flat_map { |fa| fa.spec_consumer.frameworks }.sort.uniq
kwargs[:sdk_includes] = []
kwargs[:weak_sdk_frameworks] = file_accessors.flat_map { |fa| fa.spec_consumer.weak_frameworks }.sort.uniq
if kwargs[:sdk_frameworks].include? 'XCTest' || kwargs[:weak_sdk_frameworks].include? 'XCTest'
kwargs[:testonly] = true
end

kwargs[:vendored_static_frameworks] = glob(attr: :vendored_static_frameworks, return_files: true)
kwargs[:vendored_dynamic_frameworks] = glob(attr: :vendored_dynamic_frameworks, return_files: true)
Expand Down