chore: cleanup bazel flags related to bazel 6 or below #3282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickeylev
approved these changes
Sep 20, 2025
| # Because this file isn't bundled with Bazel, so we have to conditionally | ||
| # check for this flag. | ||
| # TODO: Remove this once all supported Balze versions have this flag. | ||
| # TODO: Remove this once all supported Blaze versions have this flag. |
| def _is_singleton_depset(files): | ||
| # Bazel 6 doesn't have this helper to optimize detecting singleton depsets. | ||
| if _py_builtins: | ||
| return _py_builtins.is_singleton_depset(files) |
There was a problem hiding this comment.
Please keep the py_builtins.is_singleton_depset. It's a minor optimization, but I like it.
aignas
force-pushed
the
aignas.chore.drop-bazel-6
branch
from
48af9b2 to
f2e3791
Compare
|
So it is failing due to And the rc is soft failing, I need to check what is going on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a bunch of cleanup that we can now do.