wip: see what happens if python_path flag usage removed #3261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickeylev
changed the title
|
Hrm. Failures look to be because of the magic string the runtime env toolchain uses. Even though toolchains are enabled, it basically makes it act like they aren't, so it falls back to using I think all this needs is a powershell or batch file version of the runtime_env.sh script that calls python from path. |
|
Alternative idea: re-purpose the toolchain shebang to act as python_path ? Shebangs don't have any meaning to windows, and it's conceptually the same idea as "specify which python to run a program with" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wip checking ci