feat: allow merging multiple simpleapi indexes #2642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change users would have no way to download pytorch from multiple indexes (e.g. `cpu` version on some platforms and `gpu` on another) and use it inside a single hub repository. This brings the users necessary toggles to tell `rules_python` to search in multiple indexes for the `torch` wheels. Note, that the `index_strategy` field is going to be used only if one is setting multiple indexes via the `extra_index_urls` and not via the `index_url_overrides`. Whilst at it I have improved the `simpleapi_download` tests to also test the warning messages that we may print to the user. Fixes bazel-contrib#2622
|
FYI this does not seem to fix #2634, because in that example torch is coming from the same index URL either way |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change users would have no way to download pytorch from
multiple indexes (e.g.
cpuversion on some platforms andgpuonanother) and use it inside a single hub repository.
This brings the users necessary toggles to tell
rules_pythonto searchin multiple indexes for the
torchwheels. Note, that theindex_strategyfield is going to be used only if one is settingmultiple indexes via the
extra_index_urlsand not via theindex_url_overrides.Whilst at it I have improved the
simpleapi_downloadtests to also testthe warning messages that we may print to the user.
Fixes #2622