Skip to content

Improve mobile spacing and safe-area handling - #123

Open
battaglia-v wants to merge 2 commits into
mainfrom
codex/audit-and-improve-responsive-design
Open

Improve mobile spacing and safe-area handling#123
battaglia-v wants to merge 2 commits into
mainfrom
codex/audit-and-improve-responsive-design

Conversation

@battaglia-v

Copy link
Copy Markdown
Owner

Summary

  • add responsive spacing tokens, safe-area helpers, and touch-target utility classes to global styles
  • slim down sticky navigation/header surfaces for mobile while keeping mission summary accessible on larger screens
  • tighten hero and card padding across daily lessons, notifications, profile, practice, and translate flows for compact mobile layouts

Testing

  • npm test

Codex Task

@vercel

vercel Bot commented Nov 26, 2025

Copy link
Copy Markdown

Deployment failed with the following error:

Hobby accounts are limited to daily cron jobs. This cron expression (10 * * * *) would run more than once per day. Upgrade to the Pro plan to unlock all Cron Jobs features on Vercel.

Learn More: https://vercel.link/3Fpeeb1

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread app/globals.css Outdated
Comment on lines +120 to +124
.page-shell,
.page-shell-content {
display: flex;
flex-direction: column;
gap: var(--space-section-sm);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Prevent double spacing on page-shell layouts

The new .page-shell/.page-shell-content styles now force a flex column with gap: var(--space-section-sm) while the page wrappers still apply Tailwind space-y-* utilities (e.g. app/[locale]/daily-lessons/page.tsx line 27 uses page-shell-content … space-y-6). Because flex gaps and space-y margins both apply, every section wrapper now has roughly twice the vertical spacing (gap plus margin), leading to visibly stretched layouts across all pages using these classes. Please remove one of the two spacing mechanisms so the vertical rhythm matches the intended space-y values.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant