Standardize design tokens and UI styling - #121
Closed
battaglia-v wants to merge 2 commits into
Closed
Conversation
|
Deployment failed with the following error: Learn More: https://vercel.link/3Fpeeb1 |
There was a problem hiding this comment.
Pull request overview
This PR establishes a comprehensive design token system to standardize styling across the application. The changes introduce centralized token definitions for colors, shadows, radii, and icon properties, then systematically apply these tokens throughout UI components and feature pages.
Key changes:
- Unified design token definitions in
design-tokens.jsonandapp/theme.csswith expanded palette, elevation system, and icon sizing tokens - Updated core UI components (Button, Input, Card, Skeleton) to consume CSS variables instead of hardcoded values
- Refreshed AdminDiscoverEditor with tokenized styling, improved skeleton loading states, and standardized icon/button usage
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| design-tokens.json | Expanded token system with new surface colors, elevation shadows, icon sizes, and updated gradient angles |
| app/theme.css | Added CSS variables for radii variants (control, card, panel), shadows (sm/md/lg/focus), and icon properties (size, stroke, gap) |
| app/globals.css | Added utility classes (icon-base, icon-sm, icon-gap) and updated glass-panel/card styles to reference new token variables |
| components/ui/skeleton.tsx | Updated border-radius to use var(--radius-control) token |
| components/ui/input.tsx | Replaced hardcoded dimensions and shadows with tokenized values; updated height, padding, and border-radius |
| components/ui/card.tsx | Migrated to tokenized radius and shadow variables with simplified gradient syntax |
| components/ui/button.tsx | Comprehensive token integration: gap, radius, shadows, and icon sizing now reference CSS variables; added shadow-none to ghost variant |
| components/shell/SidebarNav.tsx | Replaced hardcoded icon sizing with icon-base and icon-gap utility classes |
| components/discover/AdminDiscoverEditor.tsx | Migrated inline button/input styling to use Button/Input components; added detailed skeleton loading state; applied tokenized radius and spacing throughout |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Owner
Author
|
Closing as duplicate of PR #128. Both PRs target the same design token standardization work, created about 1 hour apart from the same Codex task. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Codex Task