Skip to content

Conversation

frenzymadness
Copy link
Contributor

Using NotImplemented in a boolean context will now raise a TypeError. It had previously raised a DeprecationWarning since Python 3.9.

Fixes: #121

@pombredanne
Copy link
Collaborator

@frenzymadness Thanks. And @hroncok Thanks for reviewing!

@pombredanne
Copy link
Collaborator

@frenzymadness do you mind to also update the CI scripts to run on 3.11, 3.12, 3.13 and 3.14 and drop 3.6, 3.7 and 3.8 from the CI and setup? this would be awesome!

Using NotImplemented in a boolean context will now raise
a TypeError. It had previously raised a DeprecationWarning since
Python 3.9.

Fixes: bastikr#121
- Add new Pythons and drop the old ones in tox and CI.
- Split testing dependencies between testing and linting.
- Do not use deprecated `setup.py test`.
- Use the same pytest command in tox and CI.
@frenzymadness
Copy link
Contributor Author

Done. CI and testing config updated. I have to split the list of dependencies between testing and linting because there is cffi package somewhere in the dependency tree of the linting tools and that package needs to be compiled which requires header files to be installed and it's probably something you don't want to do in every run of CI. Moreover, there is no automatic test that would use these dependencies.

pombredanne and others added 6 commits April 3, 2025 11:09
Signed-off-by: Philippe Ombredanne <[email protected]>
Also add small updates and refinements

Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
Work around a bug in twine
Also apply cosmetic formatings and refine commands

Reference: pypa/twine#1216 (comment)
Signed-off-by: Philippe Ombredanne <[email protected]>
Signed-off-by: Philippe Ombredanne <[email protected]>
@pombredanne
Copy link
Collaborator

I pushed minimal updates to the CI and setup to get things working.

@pombredanne pombredanne merged commit 8b23fda into bastikr:master Apr 3, 2025
44 checks passed
@pombredanne
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Small incompatibility with Python 3.14

3 participants