Merge pull request #133 from basehub-ai/revert-132-rename-svg-icon

Revert "Rename SVG -> Icon"
basehub-ai · Jan 14, 2025 · e12adb8 · e12adb8
2 parents 195d3b7 + a17342b
commit e12adb8
Show file tree

Hide file tree

Showing 6 changed files with 7 additions and 37 deletions.
diff --git a/packages/basehub/react-icon.d.ts b/packages/basehub/react-icon.d.ts
diff --git a/packages/basehub/react-icon.js b/packages/basehub/react-icon.js
diff --git a/packages/basehub/src/react/index.ts b/packages/basehub/src/react/index.ts
@@ -5,4 +5,4 @@ export {
   type CustomBlocksBase,
   type HandlerProps as RichTextHandlerProps,
 } from "./rich-text/primitive";
-export { SVG, Icon } from "./icon/primitive";
+export { SVG } from "./svg/primitive";
diff --git a/packages/basehub/src/react/icon/index.ts → packages/basehub/src/react/svg/index.ts b/packages/basehub/src/react/icon/index.ts → packages/basehub/src/react/svg/index.ts
diff --git a/...ages/basehub/src/react/icon/primitive.tsx → packages/basehub/src/react/svg/primitive.tsx b/...ages/basehub/src/react/icon/primitive.tsx → packages/basehub/src/react/svg/primitive.tsx
@@ -110,7 +110,8 @@ const parseStyleString = (styleString: string): React.CSSProperties => {
 };
 
 /* COMPONENT */
-export const Icon = ({
+
+export const SVG = ({
   content: _content,
   children,
   components = DEFAULT_COMPONENTS,
@@ -211,11 +212,9 @@ export const Icon = ({
           .filter(Boolean);
 
         // Create the component with children if they exist
-        return children.length > 0 ? (
-          <Component {...props}>{children}</Component>
-        ) : (
-          <Component {...props} />
-        );
+        return children.length > 0
+          ? React.createElement(tag, props, children)
+          : React.createElement(tag, props);
       };
 
       if (!svgElement) return null;
@@ -231,29 +230,3 @@ export const Icon = ({
 
   return parseAndRenderSVG as React.ReactElement;
 };
-
-interface SVGProps {
-  content: string;
-  /**
-   * @deprecated Use `content` instead.
-   */
-  children?: string;
-  components?: Partial<ComponentsOverride>;
-}
-
-/**
- * @deprecated Use the `Icon` component instead.
- */
-export const SVG: React.FC<SVGProps> = ({
-  content: _content,
-  children,
-  components = DEFAULT_COMPONENTS,
-}) => {
-  console.warn(
-    "Warning: The SVG component is deprecated and will be removed in the next major version. Please use the Icon component instead."
-  );
-
-  const content = _content ?? children;
-
-  return <Icon content={content} components={components} />;
-};
diff --git a/packages/basehub/tsup-client.config.ts b/packages/basehub/tsup-client.config.ts
@@ -7,8 +7,7 @@ export default defineConfig((_options: Options) => {
     minify: false,
     dts: true,
     entry: {
-      "react-svg": "./src/react/icon/index.ts",
-      "react-icon": "./src/react/icon/index.ts",
+      "react-svg": "./src/react/svg/index.ts",
       "react-rich-text": "./src/react/rich-text/index.ts",
       "react-form": "./src/react/form/index.ts",
       "react-code-block/index": "./src/react/code-block/index.ts",