Skip to content

Conversation

@bjarneo
Copy link
Contributor

@bjarneo bjarneo commented Nov 19, 2025

The previous PR, not able to reopen after I fixed the rebase: #3316

516101443-157aaa6b-9890-4581-b33b-2ed0fbbfb527 512370367-15068acb-2717-48e4-ae7d-9496694fb901 (1)

https://marketplace.visualstudio.com/items?itemName=Bjarne.ethereal-omarchy

@bjarneo bjarneo changed the base branch from master to dev November 19, 2025 16:00
@dhh
Copy link
Member

dhh commented Nov 19, 2025

Same nvim error message as with the other theme:

image

@bjarneo
Copy link
Contributor Author

bjarneo commented Nov 19, 2025

Sorry about that. Regression fixed. Now both themes have the naming fix for neovim.lua.

@dhh dhh force-pushed the add-new-theme-ethereal branch from a67e135 to 7612519 Compare November 19, 2025 20:39
@dhh
Copy link
Member

dhh commented Nov 19, 2025

Also, I like the colors of the background, but it's too low resolution for a 6K display. We'll need to find something that doesn't show compression artifacts etc. Even though 5mb is already kinda big!

@bjarneo
Copy link
Contributor Author

bjarneo commented Nov 20, 2025

I am still looking into the lazyvim issue for the aether.nvim for both of these themes.

@bjarneo
Copy link
Contributor Author

bjarneo commented Nov 20, 2025

For both the hackerman and the ethereal theme, the neovim switch does work.

However, it is not working until the themes are downloaded, which does not happen automatically at my end if I switch from i.e. osaka-jade to hackerman (after a lazyvim cache deletion).

Is there any way to preload these themes? This is not an issue with the other native themes.

@dhh
Copy link
Member

dhh commented Nov 20, 2025

I think we need to add these themes to the omarchy-nvim package for that to work correctly, actually. I'll have a look at that.

@dhh
Copy link
Member

dhh commented Nov 20, 2025

BTW, the highlight color in nvim when you have uncommitted changes looks like it wasn't tuned for the color scheme. It's very bright cyan. Is that as intended?

image

@dhh dhh force-pushed the add-new-theme-ethereal branch from 4b9aa44 to 007685a Compare November 20, 2025 08:15
@dhh dhh added this to the 3.2 milestone Nov 20, 2025
@bjarneo
Copy link
Contributor Author

bjarneo commented Nov 20, 2025

No, not intended. It's known, but have not gotten around to fix it yet. The issue is the same for hackerman. I'll get it fixed today in aether.nvim, so regardless of this PR it will update as soon as I push the change to that repo.

@bjarneo
Copy link
Contributor Author

bjarneo commented Nov 20, 2025

No, not intended. It's known, but have not gotten around to fix it yet. The issue is the same for hackerman. I'll get it fixed today in aether.nvim, so regardless of this PR it will update as soon as I push the change to that repo.

Fixed

@dhh dhh merged commit cd2a4e4 into basecamp:dev Nov 20, 2025
@bjarneo bjarneo deleted the add-new-theme-ethereal branch November 20, 2025 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants