Skip to content

Conversation

@abenz1267
Copy link
Contributor

These changes are needed to avoid config breakage.

@dhh
Copy link
Member

dhh commented Nov 18, 2025

What is the config breakage not having this will cause? Are we in need of an emergency release to deal with it?

@abenz1267
Copy link
Contributor Author

Uhm... i'm not sure, since you host the packagebuilds yourself? If the version is somehow pinned, no issues. In worst case it will fallback to default theme.

I wasn't sure when you want to release 3.2 so i just created the PR as early as possible.

@dhh
Copy link
Member

dhh commented Nov 18, 2025

@ryanrhughes told me we're good. We've paused building our own pkgs so we don't pick up this incompatible version before we're ready to roll out 3.2.

@dhh dhh added this to the 3.2 milestone Nov 19, 2025
@philweber
Copy link

philweber commented Nov 19, 2025

What is the config breakage not having this will cause? Are we in need of an emergency release to deal with it?

Existing users who upgrade to the latest version of walker will see an error message at the bottom of menus and the launcher: “Required object ‘Keybinding’ not found”. Adding the new required objects to layout.xml will see unsightly shortcut key hints at the bottom of walker windows. I tried (unsuccessfully) to edit the omarchy-default theme to hide the shortcut hints, but ultimately rolled back to the previous version of walker.

@abenz1267
Copy link
Contributor Author

abenz1267 commented Nov 19, 2025

If you install the latest version from the AUR and not the one Omarchy ships, yeah, that will happen. This is what this PR is for.

You'd simply look at the commit (... or release notes...) to see how to hide them.

@dhh
Copy link
Member

dhh commented Nov 20, 2025

Are these changes backwards compatible? So if we merge this now, before we have the latest package, will that also give an error message or just be ignored?

@abenz1267
Copy link
Contributor Author

abenz1267 commented Nov 20, 2025

Not backwards compatible due to changed element IDs.

@ryanrhughes ryanrhughes merged commit 50ec3ce into basecamp:dev Nov 21, 2025
@dhh
Copy link
Member

dhh commented Nov 21, 2025

This still seems busted?

image image

@dhh
Copy link
Member

dhh commented Nov 21, 2025

Needed a migration to refresh the walker config and restart walker. All good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants