-
Notifications
You must be signed in to change notification settings - Fork 1.7k
fix(walker): update for breaking changes in latest version #3451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
What is the config breakage not having this will cause? Are we in need of an emergency release to deal with it? |
|
Uhm... i'm not sure, since you host the packagebuilds yourself? If the version is somehow pinned, no issues. In worst case it will fallback to default theme. I wasn't sure when you want to release 3.2 so i just created the PR as early as possible. |
|
@ryanrhughes told me we're good. We've paused building our own pkgs so we don't pick up this incompatible version before we're ready to roll out 3.2. |
Existing users who upgrade to the latest version of |
|
If you install the latest version from the AUR and not the one Omarchy ships, yeah, that will happen. This is what this PR is for. You'd simply look at the commit (... or release notes...) to see how to hide them. |
|
Are these changes backwards compatible? So if we merge this now, before we have the latest package, will that also give an error message or just be ignored? |
|
Not backwards compatible due to changed element IDs. |
|
Needed a migration to refresh the walker config and restart walker. All good. |


These changes are needed to avoid config breakage.