Skip to content

Conversation

@Kasui92
Copy link
Contributor

@Kasui92 Kasui92 commented Oct 29, 2025

This PR adds Starship to Omakub, using Omarchy’s configuration and style as a reference for consistency.

Screenshot From 2025-11-10 00-07-16

@Kasui92 Kasui92 changed the title Added Starship Adds Starship Oct 29, 2025
@Kasui92 Kasui92 changed the title Adds Starship Add Starship Oct 29, 2025
@Kasui92 Kasui92 mentioned this pull request Nov 26, 2025
@ImmortalSom
Copy link

ImmortalSom commented Nov 26, 2025

/defaults/bash/prompt

It would be worth deleting, as it loses its meaning.
See basecamp/omarchy#3295

Fix PS1 setting no longer necessary given default starship installation by @dhh

@Kasui92
Copy link
Contributor Author

Kasui92 commented Nov 26, 2025

/defaults/bash/prompt

It would be worth deleting, as it loses its meaning.

I was actually thinking about that, but the way /defaults/bash are handled here is different from Omarchy. The risk is that anyone not using Starship could suddenly end up without a prompt. We’d probably need some kind of safeguard to avoid making the change too disruptive.

With #562 we would manage them in a similar way and then maybe do the migration more "gentle".

@ImmortalSom
Copy link

ImmortalSom commented Nov 26, 2025

The risk is that anyone not using Starship could suddenly end up without a prompt.

You're mistaken. You're misinterpreting what's happening here. We substitute the system prompt. It remains, it's not going anywhere. If something goes wrong, the system prompt will appear.
This is a continuation of my argument about PS1. I insisted there that if something goes wrong, let the system prompt return.

@Kasui92
Copy link
Contributor Author

Kasui92 commented Nov 26, 2025

Anyone who doesn’t want to use Starship and prefers to stick with the old PS1 setup, with NerdFont and icons, would lose it immediately. That’s exactly what happened in Omarchy at first, because the PS1 wasn’t removed right away after Starship landed. I think the same approach makes sense here: phase it out slowly and give people who don’t want Starship a way to keep their existing prompt.

@ImmortalSom
Copy link

Anyone who doesn’t want to use Starship and prefers to stick with the old PS1 setup, with NerdFont and icons, would lose it immediately. That’s exactly what happened in Omarchy at first, because the PS1 wasn’t removed right away after Starship landed. I think the same approach makes sense here: phase it out slowly and give people who don’t want Starship a way to keep their existing prompt.

This is not the way of Omak. 😄

@Kasui92
Copy link
Contributor Author

Kasui92 commented Nov 26, 2025

Yes, of course, it’s definitely less Omakase. But between removing the PS1 entirely and keeping it no matter what (which I don’t really see the point of either), I think there’s room for a middle ground if you want to switch everything in one go.

Maybe we could consider a migration step that adds the current PS1 back into .bashrc for anyone who doesn’t want to install Starship.

Otherwise, fine by me... we can just clean up the PS1 and move on. 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants