-
Notifications
You must be signed in to change notification settings - Fork 774
Add Starship #560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add Starship #560
Conversation
|
It would be worth deleting, as it loses its meaning.
|
I was actually thinking about that, but the way With #562 we would manage them in a similar way and then maybe do the migration more "gentle". |
You're mistaken. You're misinterpreting what's happening here. We substitute the system prompt. It remains, it's not going anywhere. If something goes wrong, the system prompt will appear. |
|
Anyone who doesn’t want to use Starship and prefers to stick with the old PS1 setup, with NerdFont and icons, would lose it immediately. That’s exactly what happened in Omarchy at first, because the PS1 wasn’t removed right away after Starship landed. I think the same approach makes sense here: phase it out slowly and give people who don’t want Starship a way to keep their existing prompt. |
This is not the way of Omak. 😄 |
|
Yes, of course, it’s definitely less Omakase. But between removing the PS1 entirely and keeping it no matter what (which I don’t really see the point of either), I think there’s room for a middle ground if you want to switch everything in one go. Maybe we could consider a migration step that adds the current PS1 back into Otherwise, fine by me... we can just clean up the PS1 and move on. 👍🏻 |
This PR adds Starship to Omakub, using Omarchy’s configuration and style as a reference for consistency.