Merge pull request #36 from basecamp/fix-update-and-pattern-change

Fix update and pattern change

lib/mission_control/web/routes_cache.rb

@@ -6,15 +6,15 @@ def initialize(application)
   end
 
   def put(route)
+    remove(route)
+
     if route.disabled?
       add(route)
-    else
-      remove(route)
     end
   end
 
   def remove(route)
-    redis.srem redis_key, route.pattern.to_s
+    redis.srem redis_key, [ route.pattern_previously_was.to_s, route.pattern.to_s ]
   end
 
   def disabled?(path)

test/models/mission_control/web/route_test.rb

@@ -20,6 +20,13 @@ class MissionControl::Web::RouteTest < ActiveSupport::TestCase
     assert_not MissionControl::Web.host_application.route_disabled? "/campfire"
   end
 
+  test "updating a Route with a new pattern deletes the old pattern" do
+    @route.update!(pattern: "/chat")
+
+    assert_not MissionControl::Web.host_application.route_disabled? "/campfire"
+    assert MissionControl::Web.host_application.route_disabled? "/chat"
+  end
+
   test "destroying a Route removes the routes configuration" do
     @route.destroy!