Don't memoize node selection to deal with Lexical freezing selected nodes in development #545
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgemanrubia
force-pushed
the
frozen-selection-bug
branch
2 times, most recently
from
52839ad to
2e12227
Compare
…odes in development #540 #507 (comment)
jorgemanrubia
force-pushed
the
frozen-selection-bug
branch
from
2e12227 to
32c0001
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This deals with a problem related to Lexical in development mode. Lexical freezes selection nodes, and our previous implementation resulted in an exception in some scenarios.
See:
#540
#507 (comment)
Removing the development builds was a first attempt, but it seems this is still an issue when installing via NPM #507 (comment). This should take care of that for good.
cc @samuelpecher