Skip to content

Fix deleting selected attachments #507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bluesnotred wants to merge 2 commits into from
Closed

Fix deleting selected attachments #507

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
65635b7
Fix deleting selected attachments
bluesnotred Dec 19, 2025
6fd45b8
Fix arrow key navigation with selected attachments
bluesnotred Dec 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/editor/contents.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,8 +278,11 @@ export default class Contents {
let focusNode = null

this.editor.update(() => {
if ($isNodeSelection(this.#selection.current)) {
const nodesToRemove = this.#selection.current.getNodes()
// Use fresh selection - cached this.#selection.current may be frozen
// See: https://github.com/facebook/lexical/issues/6290
const selection = $getSelection()
if ($isNodeSelection(selection)) {
const nodesToRemove = selection.getNodes()
if (nodesToRemove.length === 0) return

focusNode = this.#findAdjacentNodeTo(nodesToRemove)
Expand Down
7 changes: 6 additions & 1 deletion src/editor/selection.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -409,7 +409,12 @@ export default class Selection {
if (this.current) {
this.editor.update(() => {
this.clear()
fn(this.current.getNodes()[0])
// Use fresh selection - cached this.current may be frozen
// See: https://github.com/facebook/lexical/issues/6290
const selection = $getSelection()
if ($isNodeSelection(selection)) {
fn(selection.getNodes()[0])
}
this.editor.focus()
})
}
Expand Down