Skip to content

Notification Settings adjustments #2249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nqst wants to merge 6 commits into
base: main
Choose a base branch
from
+6 −6
Open

Notification Settings adjustments #2249

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
77279d4
Notifications settings -> Notification Settings
nqst Dec 23, 2025
e7d8f87
Add missing comma
nqst Dec 23, 2025
3e562f0
Adjust `.notifications__status` corner radius
nqst Dec 23, 2025
2d5e441
Consistent spacing
nqst Dec 24, 2025
43d56b3
Show full browser name for Chrome in instructions
nqst Dec 24, 2025
3146fce
Merge branch 'main' into notification-settings-adjustments
nqst Dec 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/assets/stylesheets/notifications.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@
}

.notifications__status {
--panel-border-radius: 0.5em;
--panel-padding: var(--block-space);
}
}

2 changes: 1 addition & 1 deletion app/views/notifications/_tray.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
<div data-navigable-list-target="item" class="full-width">
<%= link_to notifications_settings_path,
class: "btn borderless tray__notification-settings",
title: "Notification settings",
title: "Notification Settings",
data: { action: "dialog#close" } do %>
<%= icon_tag "settings" %>
<span>Settings</span>
Expand Down
2 changes: 1 addition & 1 deletion app/views/notifications/settings/_browser.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@
<li>Click <em aria-label="the Apple menu"></em> in the top left.</li>
<li>Click <em>System Settings…</em>.</li>
<li>Click <em>Notifications</em>.</li>
<li>Click <em><%= platform.browser.capitalize %></em>.</li>
<li>Click <em><%= platform.browser == "Chrome" ? "Google Chrome" : platform.browser.capitalize %></em>.</li>
<li>Click <em><%= icon_tag "switch", alt: "the switch" %></em> to <em>Allow notifications</em>.</li>
<% end %>
</ol>
Expand Down
4 changes: 2 additions & 2 deletions app/views/notifications/settings/show.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
<% @page_title = "Notifications settings" %>
<% @page_title = "Notification Settings" %>

<% content_for :header do %>
<h1 class="header__title"><%= @page_title %></h1>
<% end %>

<section class="settings">
<section class="settings margin-block-start-half">
<div class="settings__panel settings__panel--users panel shadow center">
<h2 class="txt-medium txt-uppercase divider">Boards</h2>
<div class="settings__user-list flex flex-column gap-half">
Expand Down
2 changes: 1 addition & 1 deletion app/views/notifications/unsubscribes/show.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<div class="panel margin-block-double center shadow">
<h1 class="font-black txt-x-large margin-none-block-end">You’re unsubscribed</h1>
<p class="margin-block-start-half">Thanks, <%= @user.first_name %>! Fizzy won’t send you any more email notifications. If you change your mind you can turn them back on in <%= link_to "Notifications Settings", notifications_settings_path %>.</p>
<p class="margin-block-start-half">Thanks, <%= @user.first_name %>! Fizzy won’t send you any more email notifications. If you change your mind, you can turn them back on in <%= link_to "Notification Settings", notifications_settings_path %>.</p>

<%= link_to root_path, class: "btn btn--link margin-block-start" do %>
<%= icon_tag "arrow-left" %>
Expand Down