Restore log level configurability in production environment #2234
+5
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, production environment logs spit out debug logs, and there is no way to configure it without rebuilding the docker container. This poses both performance and security implications.
By default, Rails generates production environment config with
RAILS_LOG_LEVELenvironment variable, but a sequence of changes for the SaaS version led to removal of this:fatal, to enable structured loggingfatal(and the last mention oflog_level) from production to SaaS production, switching self-hosted version todebugThis pull request restores "info" by default, and add configurability. SaaS version overrides it with "fatal", so no changes needed there: https://github.com/basecamp/fizzy/blob/main/saas/config/environments/production.rb#L4-L6