Skip to content

Fix: Maintain search input focus after form submission #2163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
italomatos wants to merge 2 commits into
base: main
Choose a base branch
from
+7 −0
Open

Fix: Maintain search input focus after form submission #2163

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e23b871
Fix: Maintain search input focus after form submission
italomatos Dec 16, 2025
d66e2f0
remove comment and move logic to method
italomatos Dec 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions app/javascript/controllers/bar_controller.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,11 @@ export default class extends Controller {
showModalAndSubmit(event) {
this.showModal()
this.formTarget.requestSubmit()

// Restore focus to search input after turbo frame loads
Copy link
Member

@jorgemanrubia jorgemanrubia Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could consider extracting a method #restoreFocusAfterTurboFrameLoads() to remove the comment and keep the showModalAndsubmit sentences working at the same level of abstraction.

Copy link
Contributor Author

@italomatos italomatos Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much, @jorgemanrubia ! That makes a lot of sense. Thanks a lot for the review.

this.turboFrameTarget.addEventListener("turbo:frame-load", () => {
this.searchInputTarget.focus()
}, { once: true })
}

showModal() {
Expand Down