Limit the number of asignees on a card #2153
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monorkin
force-pushed
the
limit-the-number-of-asignees-on-a-card
branch
from
35b9fbd to
15cb1f7
Compare
jzimdars
approved these changes
Dec 15, 2025
Member
jzimdars
left a comment
jzimdars
left a comment
There was a problem hiding this comment.
I get why we need to do this but I'd suggest increasing the limit to the amount that provides the most protection but is large enough that almost no real user would hit it in legitimate use.
Could we make it 25, 50, 75... without compromising the protection? These kinds of limits feel arbitrary to users so my hope is that no one ever actually sees this.
That said, I made a few small tweaks to the notice display in 140399a
| </ul> | ||
|
|
||
| <div class="popup__footer" hidden data-assignment-limit-target="limitMessage"> | ||
| Maxium <%= Assignment::LIMIT %> assignees |
Collaborator
There was a problem hiding this comment.
Typo here! Maximum vs Maxium
Member
There was a problem hiding this comment.
Doh! Thanks for catching that.
Contributor
Author
There was a problem hiding this comment.
Fixed this critical failure here 52bdc8d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helps prevent DoS attacks with #2118, but also makes rendering cards and card previews more predictable.
When 10 people are assigned:
If fewer than 10 people are assigned:
