fix(internal-explorer): log shadow candidate fetch failures - #89
Closed
jowparks wants to merge 1 commit into
Closed
Conversation
fetchShadowCandidatesBatch returned an empty map for every failure mode -- unreachable host, TLS error, non-2xx, timeout, malformed payload -- without logging, so a misconfigured shadow-metrics URL was indistinguishable from a block that genuinely has no shadow candidates. Route it through fetchShadowMetrics for typed errors, log them, and preserve the underlying fetch error as the cause. Co-authored-by: OpenCode <opencode-noreply@coinbase.com> Co-Authored-By: Claude <noreply@anthropic.com>
Collaborator
🟡 Heimdall Review Status
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fetchShadowCandidatesBatchreturned an empty map for every failure — unreachable host, TLS error, non-2xx, timeout, malformed payload — with no logging, so a misconfigured shadow-metrics URL was indistinguishable from a block that genuinely has no shadow candidates. It now goes throughfetchShadowMetricsfor typed errors, logs them, and keeps the underlying fetch error as the cause.