Skip to content

Conversation

@NanoMindExplorer
Copy link

Summary

This PR refactors the Dockerfile to provide a cleaner, safer, and more efficient build process for both op-node and geth.

Changes

  • Split the Dockerfile into three distinct stages (op-node, geth, and final image)
  • Added pipefail and set -e for better error detection during build
  • Added explicit branch and commit validation for reproducible builds
  • Reduced image size by combining RUN layers and removing apt cache
  • Added metadata labels and fixed binary permissions
  • Replaced CMD with ENTRYPOINT for proper signal handling under supervisord

Motivation

Improves image reproducibility, security, and build performance.
Makes future maintenance easier by isolating build stages and improving readability.

Testing

  • Built successfully with Docker 24.0+
  • Verified that both geth and op-node binaries run correctly inside container
  • Supervisor starts and manages both processes as expected

- Refactored Dockerfile into three clear build stages: op-node, geth, and final image
- Added pipefail and set -e for safer bash execution
- Improved reproducibility with explicit branch and commit validation
- Reduced image size by combining RUN layers and removing apt cache
- Added metadata labels and executable permissions for binaries
- Replaced CMD with ENTRYPOINT for better signal handling under supervisord
@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Oct 21, 2025

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@github-actions
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the Stale label Nov 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants