Don't dirty shadow.rs unless contents have changed #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stop spurious rebuilds for any project that uses shadow-rs - even if no source has changed, because the shadow.rs file is blindly clobbered on every build, cargo thinks something has changed due to the directive to rebuild if shadow.rs changes. Instead, check if any of the new contents are actually different, ignoring the "Generation time" header.
vlovich
force-pushed
the
spurious-rebuilds
branch
from
3ae4ac0 to
2abc324
Compare
|
I think this approach may be flawed since variables changing that you expect to cause a rebuild (e.g. amending the git commit) don't. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stop spurious rebuilds for any project that uses shadow-rs - even if no source has changed, because the shadow.rs file is blindly clobbered on every build, cargo thinks something has changed due to the directive to rebuild if shadow.rs changes. Instead, check if any of the new contents are actually different, ignoring the "Generation time" header.