Conversation
There was a problem hiding this comment.
Pull request overview
This PR optimizes block data retrieval by fetching only block headers instead of full blocks when extracting block timestamps. This is a performance improvement that reduces network overhead and data transfer since only the header information is needed.
Changes:
- Replaced
GetBlockmethod withGetHeaderBlockto retrieve only block headers - Updated error messages and alert constants to reflect the new method name
- Updated mocks to match the new interface
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| relayer/chains/evm/provider.go | Updated to call GetHeaderBlock instead of GetBlock and access header.Time field directly |
| relayer/chains/evm/client.go | Renamed method from GetBlock to GetHeaderBlock, changed return type from *Block to *Header, and updated to use HeaderByNumber |
| relayer/alert/alert.go | Updated alert constant from GetBlockErrorMsg to GetHeaderBlockErrorMsg |
| internal/relayertest/mocks/chain_evm_client.go | Updated mock implementation to reflect the interface change from GetBlock to GetHeaderBlock |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Marca23
approved these changes
Jan 28, 2026
tanut32039
approved these changes
Jan 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation details
Please ensure the following requirements are met before submitting a pull request:
CHANGELOG_UNRELEASED.mdFiles changedtab in the Github PR explorer)