-
Notifications
You must be signed in to change notification settings - Fork 0
[Feat] Add XRPL #67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tanut32039
wants to merge
13
commits into
main
Choose a base branch
from
refactor-for-next-chain
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[Feat] Add XRPL #67
Changes from 12 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
c1282ce
refactor for next chain
3b2095c
fix copilot comment
702a869
fix wrong test result
6637368
add xrpl
ffe4457
refactor
d66cf75
add test
98e393e
fix metrics
a663316
fix copilot comment
b65571a
integrate with fkms
a4d5e6b
add some unit tests
4c14139
add wallet unit test
d1f39ff
fix lint
c9afe1e
fix copilot comment
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -15,8 +15,9 @@ import ( | |
|
|
||
| const ( | ||
| privateKeyLabel = "Private key (provide an existing private key)" | ||
| familySeedLabel = "Family seed (provide an existing family seed)" | ||
| mnemonicLabel = "Mnemonic (recover from an existing mnemonic phrase)" | ||
| defaultLabel = "Generate new address (no private key or mnemonic needed)" | ||
| defaultLabel = "Generate new address (no secret or mnemonic needed)" | ||
| ) | ||
|
|
||
| const ( | ||
|
|
@@ -28,6 +29,7 @@ const ( | |
| // AddKeyInput is the input for adding a key to the keychain. | ||
| type AddKeyInput struct { | ||
| PrivateKey string | ||
| FamilySeed string | ||
| Mnemonic string | ||
| CoinType uint64 | ||
| Account uint64 | ||
|
|
@@ -92,7 +94,7 @@ keys add eth test-key`), | |
|
|
||
| // if no private key, mnemonic, or remote signer info is provided, prompt interactively | ||
| if input.PrivateKey == "" && input.Mnemonic == "" && input.RemoteSigner.Address == "" && | ||
| input.RemoteSigner.Url == "" { | ||
| input.RemoteSigner.Url == "" && input.FamilySeed == "" { | ||
| input, err = showHuhPrompt() | ||
| if err != nil { | ||
| return err | ||
|
|
@@ -119,6 +121,7 @@ keys add eth test-key`), | |
| } | ||
|
|
||
| cmd.Flags().String(flagPrivateKey, "", "add key with the given private key") | ||
| cmd.Flags().String(flagFamilySeed, "", "add key with the given family seed") | ||
| cmd.Flags().String(flagMnemonic, "", "add key with the given mnemonic") | ||
| cmd.Flags().Uint64(flagCoinType, defaultCoinType, "coin type number for HD derivation") | ||
| cmd.Flags().Uint64(flagWalletAccount, 0, "account number in the HD derivation path") | ||
|
Comment on lines
123
to
127
|
||
|
|
@@ -281,14 +284,20 @@ func validateAddKeyInput(input *AddKeyInput) error { | |
| hasPrivateKey := input.PrivateKey != "" | ||
| hasMnemonic := input.Mnemonic != "" | ||
| hasRemoteSigner := input.RemoteSigner.Address != "" || input.RemoteSigner.Url != "" | ||
| hasFamilySeed := input.FamilySeed != "" | ||
|
|
||
| // if a private key is provided, no other input should be present | ||
| if hasPrivateKey && (hasMnemonic || hasRemoteSigner) { | ||
| if hasPrivateKey && (hasMnemonic || hasRemoteSigner || hasFamilySeed) { | ||
| return fmt.Errorf("private key cannot be provided with mnemonic or remote signer") | ||
| } | ||
|
|
||
| // if a family seed is provided, no other input should be present | ||
| if hasFamilySeed && (hasPrivateKey || hasMnemonic || hasRemoteSigner) { | ||
| return fmt.Errorf("family seed cannot be provided with private key or remote signer") | ||
| } | ||
|
|
||
| // if a mnemonic is provided, no other input should be present | ||
| if hasMnemonic && (hasPrivateKey || hasRemoteSigner) { | ||
| if hasMnemonic && (hasPrivateKey || hasRemoteSigner || hasFamilySeed) { | ||
| return fmt.Errorf("mnemonic cannot be provided with private key or remote signer") | ||
| } | ||
tanut32039 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
|
|
@@ -434,6 +443,11 @@ func parseKeysAddInputFromFlag(cmd *cobra.Command) (*AddKeyInput, error) { | |
| return nil, err | ||
| } | ||
|
|
||
| input.FamilySeed, err = cmd.Flags().GetString(flagFamilySeed) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
| input.PrivateKey, err = cmd.Flags().GetString(flagPrivateKey) | ||
| if err != nil { | ||
tanut32039 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| return nil, err | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.