You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
cache results
when fetching the migration data, consider adding some cache so it can load somewhat faster.
incorrect pool fee
seems that the value you display for fee is x10 higher than it actually is
for this, when you show 3%, it is actually 0.3%
incorrect token decimals
when displaying fees in usdc and usdt for example, you apply 18 decimals on the value instead of 6
incorrect token amounts in the new strategy
some amm strategies include 2 values: 1) base position 2) fees
it seems that the current process migrates the base position only and fees are sent to the user wallet.
expected: both values should be used to create the new strategy on carbon
navigate to "strategy" page
[optional - based on performance and load times for the migration page data]
at the end of the transaction to migrate position, i expect to be redirect to the strategy page
educational text
in order to enrich the information on the page and help educate the user on the process it offers, we would like to add this
text:
Upgrade your LP positions to Carbon DeFi
Move beyond shared pools with fixed parameters and turn passive positions into active, customizable strategies.
Import positions from supported DEXs, define your own price ranges, spreads, and liquidity distribution, and adjust your strategy as markets evolve — without the need to withdraw and redeploy.
Your liquidity, on your terms.
current: link to etherscan to view the transaction
updated: View Strategy(/strategy/{strategyId)
educational text
current: This tool is for informational purposes only and operates under simplified conditions. It excludes gas fees, does not support fee on transfer (tax) or rebase tokens, and may lack accuracy or completeness. Bancor accepts no liability for its use.
updated: Import positions from supported DEXs, define your own price ranges, spreads, and liquidity distribution, and adjust your strategy as markets evolve — without the need to withdraw and redeploy.
add checkbox in migration popup
on the migration popup
current: we show the "notice" text but the cta is always enabled and available.
updated: add a checkbox to the "notice" text. when checkbox is not checked, the cta to migrate should be disabled. (this is mimicking the behavior we have on create strategy flows)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #1764
How to test:
In Debug set the same Tenderly network but do not check "unchecked signer"
In Debug, at the bottom, create a V2 position (Quote amount might not be taken into account, this is expected)
Reload: you shouldn't have to wait to initial load time to see your positions
Click "Migrate" to transform this position into a Carbon strategy