Skip to content

fix(filament-manager): don't write a preset setting_id into a spool's filament id #12079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
marciogranzotto wants to merge 1 commit into
base: master
Choose a base branch
from
+1 −3
Open

fix(filament-manager): don't write a preset setting_id into a spool's filament id #12079

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions src/slic3r/GUI/DeviceWeb/device_page/src/features/filament-manager/AddEditDialog.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -520,13 +520,12 @@ export function AddEditDialog({

// STUDIO-17977 / Task 10: drive the colour palette from
// `filament.colors.query_for_id`. The same fila_id resolution as
// handleSubmit (cloud filamentId > preset setting_id > preset filament_id)
// handleSubmit (cloud filamentId > preset filament_id)
// is reused here so the candidate query keys off whatever the spool will
// actually serialise as `setting_id` on save.
const filaId = useMemo(
() => (
matchedCloudFilamentId
|| matchedPresetItem?.setting_id
|| matchedPresetItem?.filament_id
|| initSpool?.setting_id
|| ''
Expand Down Expand Up @@ -1090,7 +1089,6 @@ export function AddEditDialog({
remain_percent: remainPct,
note,
setting_id: matchedCloudFilamentId
|| matchedPresetItem?.setting_id
|| matchedPresetItem?.filament_id
|| initSpool?.setting_id
|| '',
Expand Down