FIX: Reload from disk fails when 3MF stores source as filename only - #11988
Open
ClusterM wants to merge 1 commit into
Open
FIX: Reload from disk fails when 3MF stores source as filename only#11988ClusterM wants to merge 1 commit into
ClusterM wants to merge 1 commit into
Conversation
Signed-off-by: Alexey Cluster <cluster@cluster.wtf>
Haidiye00
reviewed
Aug 28, 2026
Haidiye00
left a comment
Contributor
There was a problem hiding this comment.
Hello, please provide the GIF tests before and after the modification. Thank you
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
source.input_fileas a filename only (tpu_tube-Roller.3mf) by design (FullPathSourcesis off so shared projects do not leak full paths). After the same file is read again, the new volume gets the absolute path. The matcher used==on those strings, so a valid reload was rejected.Rollervstpu_tube-Roller.3mf). The 3MF object name and the part name on the plate already matched (Roller).Change
In
Plater::priv::reload_from_disk():