Skip to content

fix: warn user when filament serial input sanitizes to empty string #10879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BenJule wants to merge 4 commits into
base: master
Choose a base branch
from
+7 −1
Open

fix: warn user when filament serial input sanitizes to empty string #10879

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e9976f2
fix: warn user when Serial input is invalid/sanitized to empty
BenJule May 22, 2026
c677b78
fix: drop redundant empty-serial check and correct dialog message
BenJule Jul 3, 2026
8118a2d
fix: remove redundant serial empty check
BenJule Sep 2, 2026
45ae966
fix: correct serial validation guard placement
BenJule Sep 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/slic3r/GUI/CreatePresetsDialog.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1038,7 +1038,13 @@ wxBoxSizer *CreateFilamentPresetDialog::create_button_item()
}
boost::algorithm::trim(vendor_name);
boost::algorithm::trim(serial_name);
if (vendor_name.empty() || serial_name.empty()) {
if (serial_name.empty()) {

@tonghao-bbl tonghao-bbl Sep 2, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The check is duplicated with L1042

@BenJule BenJule Sep 2, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, thanks. The second condition now only checks vendor_name.empty(), since the empty serial case already returns immediately above.

@BenJule BenJule Sep 2, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correction: my previous follow-up modified the earlier guard instead of the duplicated post-trim check. This is now fixed correctly: the first validation again checks both vendor and serial, while the later condition only checks vendor_name.empty() because the empty serial case already returns immediately above.

MessageDialog dlg(this, _L("The filament serial contains only invalid characters or spaces. Please correct it."),
wxString(SLIC3R_APP_FULL_NAME) + " - " + _L("Info"), wxYES | wxYES_DEFAULT | wxCENTRE);
dlg.ShowModal();
return;
}
if (vendor_name.empty()) {
MessageDialog dlg(this, _L("All inputs in the custom vendor or serial are spaces. Please re-enter."),
wxString(SLIC3R_APP_FULL_NAME) + " - " + _L("Info"), wxYES | wxYES_DEFAULT | wxCENTRE);
dlg.ShowModal();
Expand Down
Loading