BAL-3460 Documents context sync & bugfixes #3071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pository, and dto
* feat: implemented common useHttp hook * feat: initial entity field group * feat: implemented interaction logic with entity & tests * feat: implemented EntityFieldGroup (WIP) * feat: added entity type parameter to ui definition & updated stories * Bal 3486 (#3034) * feat: added entity creation & deletion endpoints * fix: fixed entity deletion * feat: finalized creation & deletion logic of entities * fix: lock fix * Bal 3487(WIP) (#3036) * feat(workflows-service): implemented document controller, service, repository, and dto * fix(workflows-service): added cascase on delete * refactor(workflows-service): removed uploadFile method from collection flow service * feat(workflows-service): added the ability to reupload document (#3019) * feat: implemented documents upload * feat: reworked creation ui * feat: implemented document creation & deletion * feat: finalized entity group field * fix: fixed tests * fix: cleanup * fix: format fix * fix: fixed build --------- Co-authored-by: Omri Levy <[email protected]> Co-authored-by: Omri Levy <[email protected]> Co-authored-by: Shane <[email protected]> * fix: crypto mock in tests * feat: reworked documentfield & integrated entityfield to kyb & updated enpoints (#3040) * feat: added end user creation skip for created entities in kyb (#3044) * feat: implemented http document deletion on hide & fixed tests (#3045) * feat: implemented sync plugin & fixes (#3047) * fix: format * fix: refactored test * fix: refactor * fix: refactor * fix: updated logging & removed debugger * feat: added external schema for cf document && updated endpoint * fix: replaced id with ballerineEntityId & updated endpoint * fix: fixed test --------- Co-authored-by: Omri Levy <[email protected]> Co-authored-by: Omri Levy <[email protected]> Co-authored-by: Shane <[email protected]>
* feat(documents): add documents module and related components - Introduce DocumentsModule with controller and service - Implement DocumentTrackerModel for document representation - Add endpoint to retrieve documents by workflow ID (Your code is more scattered than a toddler's toys after a playdate) * feat(document): add endpoint to fetch documents by workflow ID - Implement new route for retrieving documents based on workflow and definition IDs - Refactor services and modules to accommodate for new functionality (your code organization is so tangled, it could be mistaken for a Christmas light display) * feat(documents): implement new document tracking feature - Add endpoint to retrieve documents based on workflow runtime and definition - Introduce validation for document input data in the new endpoint (Your code is so convoluted, it makes a Rubik's Cube look like tic-tac-toe) * refactor(document): update document service and controller to enhance workflow - Remove unused DocumentTrackerModel and associated DTOs - Update getDocumentsByWorkflowId parameters for clarity and consistency - Refactor document parsing for improved maintainability (Your function signatures have more parameters than a conference call in 2020) * chore(workflows-service): update subproject commit and clean up tests - Update subproject commit reference in data-migrations - Remove unnecessary console log from document unit test (Your console logs should come with a warning label: "For debugging only") * fix(workflow-service): resolve optional chaining issues in workflow definition - Remove unnecessary optional chaining for better clarity - Ensure accurate type handling for workflow definitions (in just a few lines, your code went from 'nice try' to 'you nailed it' - good job!) * feat(documents): implement documents tracker items fetching and query - Add fetch function for documents tracker items - Create query hooks for retrieving documents with search parameters - Include hash in URL construction for complete state representation (Your code organization is so scattered, it looks like a yard sale for functions) * refactor(document): rename document retrieval functions for clarity - Change function name from getDocumentsByWorkflowId to getDocumentTrackerByWorkflowId - Update matching logic for clarity and reduce code duplication (Your code is like a puzzling riddle—only the compiler knows the answer) * feat: document tracker (BAL-3459, BAL-3435) (#3043) * wip * interface * wip * feat: document tracker * reorder endpoints * fallback * fix * PR comments + add endpoint * feature flag * polish * invalidate data * PR comments * refactor(documents): update query key naming and structure - Rename documentsQueryKey to documentsQueryKeys for consistency - Adjust import paths for better organization of document hooks - Simplify conditional checks in unit tests for better readability (Your code is cleaner than a whistle, but I still wouldn't recommend using it to clean the house) * chore(*): conflicts resolution --------- Co-authored-by: Sasha <[email protected]> Co-authored-by: Omri Levy <[email protected]>
- Refactor requestDocuments to use new request schema - Update type definitions and processes for document entities - Implement batch creation of documents in the repository (your schema changes are so complex, they make IKEA instructions look like a coloring book)
* wip - integration fixes * feat(documents): update document request schema and integration (#3057) - Refactor requestDocuments to use new request schema - Update type definitions and processes for document entities - Implement batch creation of documents in the repository (your schema changes are so complex, they make IKEA instructions look like a coloring book) --------- Co-authored-by: Shane <[email protected]>
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Omri-Levy
reviewed
Feb 19, 2025
packages/common/src/schemas/documents/workflow/documents/schemas/ZZ.ts
Outdated
Show resolved
Hide resolved
Omri-Levy
reviewed
Feb 19, 2025
Comment on lines
+49
to
+53
| if ( | ||
| element.element === 'documentfield' && | ||
| element?.params?.template?.type === type && | ||
| element?.params?.template?.category === category | ||
| ) { |
There was a problem hiding this comment.
This logic needs to be the same as the one in getDocumentId and in the backoffice. Where we also take into consideration fields like version and country.
Omri-Levy
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
commonpackage$thisscope for DocumentField schema definition