Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make some Java classes proper utilities #522

Conversation

vil02
Copy link
Contributor

@vil02 vil02 commented Oct 16, 2023

Purpose

Closes ballerina-platform/ballerina-library#4940.

Examples

Checklist

  • Linked to an issue
  • Updated the changelog
  • Added tests
  • Updated the spec
  • Checked native-image compatibility

@vil02 vil02 requested a review from shafreenAnfar as a code owner October 16, 2023 20:21
@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c31803d) 81.81% compared to head (c4371d2) 81.95%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #522      +/-   ##
============================================
+ Coverage     81.81%   81.95%   +0.14%     
  Complexity        9        9              
============================================
  Files            20       20              
  Lines          1160     1158       -2     
  Branches        283      283              
============================================
  Hits            949      949              
+ Misses          129      127       -2     
  Partials         82       82              
Files Coverage Δ
...a/io/ballerina/stdlib/mime/util/MimeConstants.java 90.90% <ø> (+3.95%) ⬆️
...ava/io/ballerina/stdlib/mime/testutils/Assert.java 21.42% <ø> (+1.42%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

vil02 added 2 commits October 18, 2023 07:35
Made the design cleaner by marking Java classes as `final`
and explicitly declaring their default constructors as `private`.
This change makes the code coverage reports more accurate.
Closes #4940.
@vil02 vil02 force-pushed the 4940_make_some_java_classes_proper_utilities branch from 595c289 to 00a2c99 Compare October 18, 2023 05:35
@vil02
Copy link
Contributor Author

vil02 commented Oct 19, 2023

@shafreenAnfar could you please approve the workflows?

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@TharmiganK TharmiganK merged commit e5e5781 into ballerina-platform:master Oct 23, 2023
7 checks passed
@vil02 vil02 deleted the 4940_make_some_java_classes_proper_utilities branch October 23, 2023 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make some of the Java classes in module-mime proper utility classes
2 participants