Add support for Tiingo API #23
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit c252629.
Add support for Tiingo API
balassy
reviewed
Apr 17, 2023
balassy
reviewed
Apr 17, 2023
| "eslint": "^7.7.0", | ||
| "eslint-config-airbnb-base": "^14.2.0", | ||
| "eslint-plugin-import": "^2.22.0", | ||
| "markdownlint-cli": "^0.23.2" | ||
| "markdownlint-cli": "^0.33.0" |
There was a problem hiding this comment.
❤️ Thank you very much for updating these!
balassy
reviewed
Apr 17, 2023
| throw new Error(`Invalid URL: ${url}`); | ||
| } else { | ||
| // eslint-disable-next-line no-restricted-globals | ||
| let corsUrl = `${location.protocol}//${location.host}/cors?`; |
There was a problem hiding this comment.
🙋♂️ I'm not familiar with this endpoint, is this a CORS proxy service of MagicMirror? Does it really need for Tiingo, it does not support browsers?
There was a problem hiding this comment.
I'm honestly primarily a backend dev so dealing with CORS was a bit new for me but it was required for Tiingo. I pretty much pulled the code from the default magic mirror utils code. I couldn't figure out how to directly use it.
|
Hello @tdadah, Thank you very much for your PR, I appreciate your contribution, especially that you have taken extra care to comment your code and extend the documentation. Great work, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been having issue with the IEX Cloud API so I've added the ability to use the Tiingo API.