Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit Tests: Functions in the Swap path #397

Merged
merged 31 commits into from
Mar 21, 2024
Merged

Unit Tests: Functions in the Swap path #397

merged 31 commits into from
Mar 21, 2024

Conversation

joaobrunoah
Copy link
Contributor

@joaobrunoah joaobrunoah commented Mar 15, 2024 •
edited
Loading

Description

Create tests for functions in the Swap/AddLiquidity/RemoveLiquidity paths, described by #387

Type of change

  • Bug fix
  • New feature
  • Breaking change
  • Dependency changes
  • Code refactor / cleanup
  • Documentation or wording changes
  • Other

Checklist:

  • The diff is legible and has no extraneous changes
  • Complex code has been commented, including external interfaces
  • Tests have 100% code coverage
  • The base branch is either main, or there's a description of how to merge

Issue Resolution

Closes #390
Closes #400
Closes #401
Closes #402
Closes #403

@joaobrunoah joaobrunoah marked this pull request as ready for review March 18, 2024 13:33
@joaobrunoah joaobrunoah self-assigned this Mar 18, 2024
@joaobrunoah joaobrunoah changed the title Testing swap functions Unit Tests: Functions in the Swap path Mar 18, 2024
jubeira
jubeira reviewed Mar 19, 2024
View reviewed changes
Copy link
Contributor

@jubeira jubeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great starting point @joaobrunoah! Nicely done; I like the approach.

I've left a bunch of minor comments; PTAL :)

pkg/vault/contracts/test/VaultMock.sol Outdated Show resolved Hide resolved
pkg/vault/contracts/test/VaultMock.sol Outdated Show resolved Hide resolved
pkg/vault/contracts/test/VaultMock.sol Show resolved Hide resolved
pkg/vault/test/foundry/unit/PoolAndVaultPaused.t.sol Outdated Show resolved Hide resolved
pkg/vault/test/foundry/unit/VaultCommonBasicFunctions.t.sol Outdated Show resolved Hide resolved
pkg/vault/test/foundry/unit/VaultCommonBasicFunctions.t.sol Outdated Show resolved Hide resolved
pkg/vault/test/foundry/unit/VaultCommonBasicFunctions.t.sol Outdated Show resolved Hide resolved
pkg/vault/test/foundry/unit/VaultCommonBasicFunctions.t.sol Outdated Show resolved Hide resolved
pkg/vault/test/foundry/unit/VaultCommonBasicFunctions.t.sol Outdated Show resolved Hide resolved
jubeira
jubeira approved these changes Mar 21, 2024
View reviewed changes
Copy link
Contributor

@jubeira jubeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great job! Just a few minor comments, otherwise it's ready to 🚢

pkg/vault/test/foundry/unit/PoolAndVaultPaused.t.sol Outdated Show resolved Hide resolved
pkg/vault/test/foundry/unit/VaultCommonBasicFunctions.t.sol Show resolved Hide resolved
pkg/vault/test/foundry/unit/VaultCommonModifiers.t.sol Outdated Show resolved Hide resolved
pkg/vault/test/foundry/unit/VaultCommonModifiers.t.sol Outdated Show resolved Hide resolved
@joaobrunoah joaobrunoah merged commit 28ee480 into main Mar 21, 2024
10 checks passed
@joaobrunoah joaobrunoah deleted the testing-swap-functions branch March 21, 2024 18:54
@joaobrunoah joaobrunoah mentioned this pull request Mar 25, 2024
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jubeira jubeira jubeira approved these changes

Assignees

@joaobrunoah joaobrunoah

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@joaobrunoah @jubeira