Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add events for initial aggregate pool fees #1250

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Add events for initial aggregate pool fees #1250

wants to merge 7 commits into from

Conversation

EndymionJkb
Copy link
Collaborator

Description

Add events to track the initial aggregate fee percentages for pools. Otherwise, there would be no indication (off-chain) that a pool was registered as protocol fee exempt.

Type of change

  • Bug fix
  • New feature
  • Breaking change
  • Dependency changes
  • Code refactor / cleanup
  • Optimization: [ ] gas / [ ] bytecode
  • Documentation or wording changes
  • Other

Checklist:

  • The diff is legible and has no extraneous changes
  • Complex code has been commented, including external interfaces
  • Tests have 100% code coverage
  • The base branch is either main, or there's a description of how to merge

Issue Resolution

Resolves #1247

@EndymionJkb EndymionJkb changed the title Initial aggregate fees Add events for initial aggregate pool fees Jan 22, 2025
@jubeira jubeira requested a review from mendesfabio January 22, 2025 21:06
@jubeira
Copy link
Contributor

jubeira commented Jan 22, 2025

Thanks @EndymionJkb; this looks good.

Adding @mendesfabio to the loop.

@jubeira jubeira mentioned this pull request Jan 23, 2025
Open
joaobrunoah
joaobrunoah approved these changes Jan 29, 2025
View reviewed changes
Copy link
Contributor

@joaobrunoah joaobrunoah left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! We don't set the aggregate fee percentages after initialization, so using the same events for the initial value and the fee percentage setters doesn't make sense.

jubeira
jubeira approved these changes Feb 7, 2025
View reviewed changes
Copy link
Contributor

@jubeira jubeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I've added the flag too. It's a bit redundant, but I don't see how it can hurt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jubeira jubeira jubeira approved these changes

@joaobrunoah joaobrunoah joaobrunoah approved these changes

@mendesfabio mendesfabio Awaiting requested review from mendesfabio

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pool fee events
3 participants
@EndymionJkb @jubeira @joaobrunoah