Bajnokk #1
Open
Bajnokk #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bajnokk
commented
May 13, 2021
src/pyop/storage.py
Outdated
|
|
||
| @ttl.setter | ||
| def ttl(self, ttl): | ||
| # Changing the expiry does not affect stored records. |
Owner
Author
There was a problem hiding this comment.
This comment is (will be) false for MongoDB
bajnokk
force-pushed
the
bajnokk
branch
2 times, most recently
from
4fc78a9 to
b7c32b8
Compare
This change adds Redis as an alternative storage backend.
Implementation notes:
- The database name (which is a number) should be provided in the
connection URI.
- The keys are prefixed with the 'collection' string, so that it is
possible to share the same database with other applications.
- All values are stored as JSON documents ({"value": value}) in order to
try to keep the original data type, since Redis stores all values as bytes.
Note however that it is still possible that the retrieved object differs
from the stored one. (Dictionaries with non-string keys are an example.)
- All values are stored together with a TTL. The TTL is None by default,
which means that the record never expires. The TTL value can be set
during initialisation.
This commit changes the storage tests to use 'fakeredis' and 'mongomock'
instead of trying to launch a real MongoDB server. Expiration tests
have been added, too.
This changes the record layout in MongoDB so that the modification time is now stored as a datetime object instead of a timestamp. It enables us to create an auto-expiry index on that field. Note that expiring objects is an asynchronous task in MongoDB. Unlike Redis, MongoDB uses collection-level expiry settings, therefore it is not possible to create multiple wrapper objects that operate on the same collection with different TTL values. Additionally, there is a minor change that allows specifying the database name in the URI instead of an argument. In case the name is specified both in the URI and the argument, the one in the argument is silently ignored.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support Redis backend and automatic session expiry