feat: images 支持图集排列方式 #11490
Merged
feat: images 支持图集排列方式 #11490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 11, 2025 10:17
|
👍 Thanks for this! Please review the labels and make any necessary changes. |
2betop
reviewed
Jan 14, 2025
added 8 commits
January 14, 2025 10:38
added 11 commits
January 16, 2025 17:15
2betop
reviewed
Feb 13, 2025
| if (!this.props.fontStyle) { | ||
| return {}; | ||
| } | ||
| console.log(this.props.fontStyle); |
2betop
reviewed
Feb 13, 2025
| '"$2": "$4"' | ||
| ); | ||
| styleObj = JSON.parse(validJsonStr); | ||
| } else if (typeof this.props.fontStyle === 'object') { |
There was a problem hiding this comment.
补充：&& this.props.fontStyle !== null
2betop
reviewed
Feb 13, 2025
| } | ||
| console.log(this.props.fontStyle); | ||
| let styleObj: object = {}; | ||
| if (typeof this.props.fontStyle === 'string') { |
There was a problem hiding this comment.
fontStyle 为何不直接要求用户配置成对象，而是 json 字符串？
2betop
reviewed
Feb 13, 2025
|
|
||
| /** | ||
| * 排列方式 | ||
| * 类命名方式按照上下左右四个边命名，l=2m，m=2s，最小单位为s |
2betop
reviewed
Feb 13, 2025
| return (width - this.gap * 2) / 3; | ||
| } else { | ||
| return (width - this.gap) / 2; | ||
| } |
hsm-lv
requested changes
Feb 13, 2025
| constructor(props: ImagesProps) { | ||
| super(props); | ||
| this.state = { | ||
| enLargeUrl: '' |
2betop
reviewed
Feb 13, 2025
|
|
||
|
|
||
|
|
||
| .enlarge-container{ |
added 13 commits
February 13, 2025 11:23
2betop
approved these changes
Feb 13, 2025
added 2 commits
February 13, 2025 20:31
hsm-lv
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
修改Images组件，添加图集排序样式
Why
丰富排序样式
How
通过新增sortType字段分辨排序样式，不传入sortType字段，按照原来组件渲染。