Fix Patreon member count to exclude members with irregular tier names #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The total count now only includes members whose tier exactly matches one of the three recognized tiers (/usr/bin/env bash, /bin/bash, /bin/sh). Previously, the total showed all active patrons while the tier subtotals only showed members with recognized tier names, causing the total to be greater than the sum of the subtotals. This change ensures the total equals the sum of the three tier counts by filtering out members with irregular or unrecognized tier names from the total. PR reviewers may want to instead handle members with incorrect tier names differently (e.g., by updating tier names in the source data or displaying them separately).
Owner
|
this is great! thank you for taking the time to make this change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The total count now only includes members whose tier exactly matches one of the three recognized tiers (/usr/bin/env bash, /bin/bash, /bin/sh).
Previously, the total showed all active patrons while the tier subtotals only showed members with recognized tier names, causing the total to be greater than the sum of the subtotals.
This change ensures the total equals the sum of the three tier counts by filtering out members with irregular or unrecognized tier names from the total. PR reviewers may want to instead handle members with incorrect tier names differently (e.g., by updating tier names in the source data or displaying them separately).