Skip to content

fixing bug in proliferation module

88c8446
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Draft

Adding fly stem cells #217

fixing bug in proliferation module
88c8446
Select commit
Loading
Failed to load commit list.
GitHub Actions / checkstyle completed Apr 22, 2026 in 1s

reviewdog [checkstyle] report

reported by reviewdog 🐶

Findings (55)

test/arcade/potts/sim/Potts3DTest.java|1| File length is 2,371 lines (max allowed is 2,000).
test/arcade/potts/env/location/PottsLocation3DTest.java|305 col 9| Avoid nested blocks.
test/arcade/potts/agent/module/PottsModuleProliferationVolumeBasedDivisionTest.java|18 col 9| 'VARIABLE_DEF' should be separated from previous line.
test/arcade/potts/agent/module/PottsModuleFlyStemProliferationTest.java|65 col 11| Name 'EPSILON' must match pattern '^[a-z][a-zA-Z0-9]$'.
test/arcade/potts/agent/module/PottsModuleFlyStemProliferationTest.java|645 col 41| 'module' hides a field.
test/arcade/potts/agent/module/PottsModuleFlyStemProliferationTest.java|685 col 41| 'module' hides a field.
test/arcade/potts/agent/module/PottsModuleFlyStemProliferationTest.java|1199 col 7| Comment matches to-do format 'TODO:'.
test/arcade/potts/agent/module/PottsModuleFlyStemProliferationTest.java|1257 col 41| 'module' hides a field.
test/arcade/potts/agent/module/PottsModuleFlyStemProliferationTest.java|1274 col 41| 'module' hides a field.
src/arcade/potts/sim/PottsSeries.java|215 col 15| Comment matches to-do format 'TODO:'.
src/arcade/potts/agent/cell/PottsCellFlyStem.java|14 col 1| Missing a Javadoc comment.
src/arcade/potts/agent/cell/PottsCellFlyStem.java|57 col 5| Missing a Javadoc comment.
src/arcade/potts/agent/cell/PottsCellFlyStem.java|89 col 5| Class 'PottsCellFlyStem' looks like designed for extension (can be subclassed), but the method 'setApicalAxis' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'PottsCellFlyStem' final or making the method 'setApicalAxis' static/final/abstract/empty, or adding allowed annotation for the method.
src/arcade/potts/agent/cell/PottsCellFlyStem.java|89 col 5| Missing a Javadoc comment.
src/arcade/potts/agent/cell/PottsCellFlyStem.java|110| Line is longer than 120 characters (found 151).
src/arcade/potts/agent/cell/PottsCellFlyStem.java|113 col 5| Class 'PottsCellFlyStem' looks like designed for extension (can be subclassed), but the method 'make' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'PottsCellFlyStem' final or making the method 'make' static/final/abstract/empty, or adding allowed annotation for the method.
src/arcade/potts/agent/cell/PottsCellFlyStem.java|113 col 5| Missing a Javadoc comment.
src/arcade/potts/agent/module/PottsModuleFlyStemProliferation.java|33 col 1| Missing a Javadoc comment.
src/arcade/potts/agent/module/PottsModuleFlyStemProliferation.java|68 col 5| Missing a Javadoc comment.
src/arcade/potts/agent/module/PottsModuleFlyStemProliferation.java|91 col 5| Missing a Javadoc comment.
src/arcade/potts/agent/module/PottsModuleFlyStemProliferation.java|93 col 5| Missing a Javadoc comment.
src/arcade/potts/agent/module/PottsModuleFlyStemProliferation.java|103 col 5| Missing a Javadoc comment.
src/arcade/potts/agent/module/PottsModuleFlyStemProliferation.java|202 col 37| Expression can be simplified.
src/arcade/potts/agent/module/PottsModuleFlyStemProliferation.java|204 col 54| Expression can be simplified.
src/arcade/potts/agent/module/PottsModuleFlyStemProliferation.java|211 col 5| Class 'PottsModuleFlyStemProliferation' looks like designed for extension (can be subclassed), but the method 'updateVolumeBasedGrowthRate' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'PottsModuleFlyStemProliferation' final or making the method 'updateVolumeBasedGrowthRate' static/final/abstract/empty, or adding allowed annotation for the method.
src/arcade/potts/agent/module/PottsModuleFlyStemProliferation.java|211 col 5| Missing a Javadoc comment.
src/arcade/potts/agent/module/PottsModuleFlyStemProliferation.java|213 col 21| Expression can be simplified.
src/arcade/potts/agent/module/PottsModuleFlyStemProliferation.java|282 col 5| Class 'PottsModuleFlyStemProliferation' looks like designed for extension (can be subclassed), but the method 'updateGrowthRateBasedOnOtherNBs' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'PottsModuleFlyStemProliferation' final or making the method 'updateGrowthRateBasedOnOtherNBs' static/final/abstract/empty, or adding allowed annotation for the method.
src/arcade/potts/agent/module/PottsModuleFlyStemProliferation.java|282 col 5| Missing a Javadoc comment.
src/arcade/potts/agent/module/PottsModuleFlyStemProliferation.java|291 col 16| Name 'Kn' must match pattern '^([a-z][a-zA-Z0-9]
|)$'.
src/arcade/potts/agent/module/PottsModuleFlyStemProliferation.java|292 col 16| Name 'Npn' must match pattern '^([a-z][a-zA-Z0-9]*|
)$'.
src/arcade/potts/agent/module/PottsModuleFlyStemProliferation.java|342 col 16| Name 'apical_axis' must match pattern '^([a-z][a-zA-Z0-9]|_)$'.
src/arcade/potts/agent/module/PottsModuleFlyStemProliferation.java|384 col 22| Expected @param tag for 'stemType'.
src/arcade/potts/agent/module/PottsModuleFlyStemProliferation.java|384 col 62| Expected @param tag for 'rotatedNormalVector'.
src/arcade/potts/agent/module/PottsModuleFlyStemProliferation.java|408 col 17| Conditional logic can be removed.
src/arcade/potts/agent/module/PottsModuleFlyStemProliferation.java|431 col 5| Missing a Javadoc comment.
src/arcade/potts/agent/module/PottsModuleFlyStemProliferation.java|490| First sentence should end with a period.
src/arcade/potts/agent/module/PottsModuleFlyStemProliferation.java|518| First sentence should end with a period.
src/arcade/potts/agent/module/PottsModuleFlyStemProliferation.java|588| Line is longer than 120 characters (found 131).
src/arcade/potts/agent/module/PottsModuleFlyStemProliferation.java|601| Line is longer than 120 characters (found 131).
src/arcade/potts/agent/module/PottsModuleFlyStemProliferation.java|637| First sentence should end with a period.
src/arcade/potts/agent/module/PottsModuleFlyStemProliferation.java|692 col 5| Class 'PottsModuleFlyStemProliferation' looks like designed for extension (can be subclassed), but the method 'getNBsInSimulation' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'PottsModuleFlyStemProliferation' final or making the method 'getNBsInSimulation' static/final/abstract/empty, or adding allowed annotation for the method.
src/arcade/potts/agent/module/PottsModuleFlyStemProliferation.java|692 col 5| Missing a Javadoc comment.
src/arcade/potts/agent/module/PottsModuleFlyStemProliferation.java|697 col 13| 'if' construct must use '{}'s.
src/arcade/potts/agent/module/PottsModuleFlyGMCDifferentiation.java|26 col 5| Missing a Javadoc comment.
src/arcade/potts/agent/module/PottsModuleFlyGMCDifferentiation.java|129 col 5| Class 'PottsModuleFlyGMCDifferentiation' looks like designed for extension (can be subclassed), but the method 'updateGrowthRate' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'PottsModuleFlyGMCDifferentiation' final or making the method 'updateGrowthRate' static/final/abstract/empty, or adding allowed annotation for the method.
src/arcade/potts/agent/module/PottsModuleFlyGMCDifferentiation.java|129 col 5| Missing a Javadoc comment.
src/arcade/potts/agent/module/PottsModuleFlyGMCDifferentiation.java|151 col 21| 'if' construct must use '{}'s.
src/arcade/potts/agent/module/PottsModuleFlyGMCDifferentiation.java|154 col 21| 'if' construct must use '{}'s.
src/arcade/potts/agent/module/PottsModuleProliferationVolumeBasedDivision.java|70 col 5| Class 'PottsModuleProliferationVolumeBasedDivision' looks like designed for extension (can be subclassed), but the method 'updateCellVolumeBasedGrowthRate' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'PottsModuleProliferationVolumeBasedDivision' final or making the method 'updateCellVolumeBasedGrowthRate' static/final/abstract/empty, or adding allowed annotation for the method.
src/arcade/potts/agent/module/PottsModuleProliferationVolumeBasedDivision.java|70 col 5| Missing a Javadoc comment.
src/arcade/potts/agent/module/PottsModuleProliferationVolumeBasedDivision.java|71 col 16| Name 'Ka' must match pattern '^([a-z][a-zA-Z0-9]
|_)$'.
src/arcade/patch/sim/output/PatchOutputSerializer.java|158 col 15| Comment matches to-do format 'TODO:'.
src/arcade/patch/agent/module/PatchModuleMigration.java|62 col 23| Comment matches to-do format 'TODO:'.
src/arcade/patch/agent/module/PatchModuleProliferation.java|128 col 23| Comment matches to-do format 'TODO:'.

Filtered Findings (0)

Annotations

Check warning on line 1 in test/arcade/potts/sim/Potts3DTest.java

See this annotation in the file changed.

@github-actions github-actions / checkstyle

[checkstyle] test/arcade/potts/sim/Potts3DTest.java#L1 <FileLengthWarn>

File length is 2,371 lines (max allowed is 2,000).
Raw output
/github/workspace/./test/arcade/potts/sim/Potts3DTest.java:1:0: warning: File length is 2,371 lines (max allowed is 2,000). (FileLengthWarn)

Check failure on line 305 in test/arcade/potts/env/location/PottsLocation3DTest.java

See this annotation in the file changed.

@github-actions github-actions / checkstyle

[checkstyle] test/arcade/potts/env/location/PottsLocation3DTest.java#L305 <com.puppycrawl.tools.checkstyle.checks.blocks.AvoidNestedBlocksCheck>

Avoid nested blocks.
Raw output
/github/workspace/./test/arcade/potts/env/location/PottsLocation3DTest.java:305:9: error: Avoid nested blocks. (com.puppycrawl.tools.checkstyle.checks.blocks.AvoidNestedBlocksCheck)

Check failure on line 18 in test/arcade/potts/agent/module/PottsModuleProliferationVolumeBasedDivisionTest.java

See this annotation in the file changed.

@github-actions github-actions / checkstyle

[checkstyle] test/arcade/potts/agent/module/PottsModuleProliferationVolumeBasedDivisionTest.java#L18 <com.puppycrawl.tools.checkstyle.checks.whitespace.EmptyLineSeparatorCheck>

'VARIABLE_DEF' should be separated from previous line.
Raw output
/github/workspace/./test/arcade/potts/agent/module/PottsModuleProliferationVolumeBasedDivisionTest.java:18:9: error: 'VARIABLE_DEF' should be separated from previous line. (com.puppycrawl.tools.checkstyle.checks.whitespace.EmptyLineSeparatorCheck)

Check failure on line 65 in test/arcade/potts/agent/module/PottsModuleFlyStemProliferationTest.java

See this annotation in the file changed.

@github-actions github-actions / checkstyle

[checkstyle] test/arcade/potts/agent/module/PottsModuleFlyStemProliferationTest.java#L65 <com.puppycrawl.tools.checkstyle.checks.naming.MemberNameCheck>

Name 'EPSILON' must match pattern '^[a-z][a-zA-Z0-9]*$'.
Raw output
/github/workspace/./test/arcade/potts/agent/module/PottsModuleFlyStemProliferationTest.java:65:11: error: Name 'EPSILON' must match pattern '^[a-z][a-zA-Z0-9]*$'. (com.puppycrawl.tools.checkstyle.checks.naming.MemberNameCheck)

Check failure on line 645 in test/arcade/potts/agent/module/PottsModuleFlyStemProliferationTest.java

See this annotation in the file changed.

@github-actions github-actions / checkstyle

[checkstyle] test/arcade/potts/agent/module/PottsModuleFlyStemProliferationTest.java#L645 <com.puppycrawl.tools.checkstyle.checks.coding.HiddenFieldCheck>

'module' hides a field.
Raw output
/github/workspace/./test/arcade/potts/agent/module/PottsModuleFlyStemProliferationTest.java:645:41: error: 'module' hides a field. (com.puppycrawl.tools.checkstyle.checks.coding.HiddenFieldCheck)

Check failure on line 685 in test/arcade/potts/agent/module/PottsModuleFlyStemProliferationTest.java

See this annotation in the file changed.

@github-actions github-actions / checkstyle

[checkstyle] test/arcade/potts/agent/module/PottsModuleFlyStemProliferationTest.java#L685 <com.puppycrawl.tools.checkstyle.checks.coding.HiddenFieldCheck>

'module' hides a field.
Raw output
/github/workspace/./test/arcade/potts/agent/module/PottsModuleFlyStemProliferationTest.java:685:41: error: 'module' hides a field. (com.puppycrawl.tools.checkstyle.checks.coding.HiddenFieldCheck)

Check warning on line 1199 in test/arcade/potts/agent/module/PottsModuleFlyStemProliferationTest.java

See this annotation in the file changed.

@github-actions github-actions / checkstyle

[checkstyle] test/arcade/potts/agent/module/PottsModuleFlyStemProliferationTest.java#L1199 <com.puppycrawl.tools.checkstyle.checks.TodoCommentCheck>

Comment matches to-do format 'TODO:'.
Raw output
/github/workspace/./test/arcade/potts/agent/module/PottsModuleFlyStemProliferationTest.java:1199:7: warning: Comment matches to-do format 'TODO:'. (com.puppycrawl.tools.checkstyle.checks.TodoCommentCheck)

Check failure on line 1257 in test/arcade/potts/agent/module/PottsModuleFlyStemProliferationTest.java

See this annotation in the file changed.

@github-actions github-actions / checkstyle

[checkstyle] test/arcade/potts/agent/module/PottsModuleFlyStemProliferationTest.java#L1257 <com.puppycrawl.tools.checkstyle.checks.coding.HiddenFieldCheck>

'module' hides a field.
Raw output
/github/workspace/./test/arcade/potts/agent/module/PottsModuleFlyStemProliferationTest.java:1257:41: error: 'module' hides a field. (com.puppycrawl.tools.checkstyle.checks.coding.HiddenFieldCheck)

Check failure on line 1274 in test/arcade/potts/agent/module/PottsModuleFlyStemProliferationTest.java

See this annotation in the file changed.

@github-actions github-actions / checkstyle

[checkstyle] test/arcade/potts/agent/module/PottsModuleFlyStemProliferationTest.java#L1274 <com.puppycrawl.tools.checkstyle.checks.coding.HiddenFieldCheck>

'module' hides a field.
Raw output
/github/workspace/./test/arcade/potts/agent/module/PottsModuleFlyStemProliferationTest.java:1274:41: error: 'module' hides a field. (com.puppycrawl.tools.checkstyle.checks.coding.HiddenFieldCheck)

Check warning on line 215 in src/arcade/potts/sim/PottsSeries.java

See this annotation in the file changed.

@github-actions github-actions / checkstyle

[checkstyle] src/arcade/potts/sim/PottsSeries.java#L215 <com.puppycrawl.tools.checkstyle.checks.TodoCommentCheck>

Comment matches to-do format 'TODO:'.
Raw output
/github/workspace/./src/arcade/potts/sim/PottsSeries.java:215:15: warning: Comment matches to-do format 'TODO:'. (com.puppycrawl.tools.checkstyle.checks.TodoCommentCheck)

Check failure on line 14 in src/arcade/potts/agent/cell/PottsCellFlyStem.java

See this annotation in the file changed.

@github-actions github-actions / checkstyle

[checkstyle] src/arcade/potts/agent/cell/PottsCellFlyStem.java#L14 <com.puppycrawl.tools.checkstyle.checks.javadoc.MissingJavadocTypeCheck>

Missing a Javadoc comment.
Raw output
/github/workspace/./src/arcade/potts/agent/cell/PottsCellFlyStem.java:14:1: error: Missing a Javadoc comment. (com.puppycrawl.tools.checkstyle.checks.javadoc.MissingJavadocTypeCheck)

Check failure on line 57 in src/arcade/potts/agent/cell/PottsCellFlyStem.java

See this annotation in the file changed.

@github-actions github-actions / checkstyle

[checkstyle] src/arcade/potts/agent/cell/PottsCellFlyStem.java#L57 <com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocVariableCheck>

Missing a Javadoc comment.
Raw output
/github/workspace/./src/arcade/potts/agent/cell/PottsCellFlyStem.java:57:5: error: Missing a Javadoc comment. (com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocVariableCheck)

Check failure on line 89 in src/arcade/potts/agent/cell/PottsCellFlyStem.java

See this annotation in the file changed.

@github-actions github-actions / checkstyle

[checkstyle] src/arcade/potts/agent/cell/PottsCellFlyStem.java#L89 <com.puppycrawl.tools.checkstyle.checks.design.DesignForExtensionCheck>

Class 'PottsCellFlyStem' looks like designed for extension (can be subclassed), but the method 'setApicalAxis' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'PottsCellFlyStem' final or making the method 'setApicalAxis' static/final/abstract/empty, or adding allowed annotation for the method.
Raw output
/github/workspace/./src/arcade/potts/agent/cell/PottsCellFlyStem.java:89:5: error: Class 'PottsCellFlyStem' looks like designed for extension (can be subclassed), but the method 'setApicalAxis' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'PottsCellFlyStem' final or making the method 'setApicalAxis' static/final/abstract/empty, or adding allowed annotation for the method. (com.puppycrawl.tools.checkstyle.checks.design.DesignForExtensionCheck)

Check failure on line 89 in src/arcade/potts/agent/cell/PottsCellFlyStem.java

See this annotation in the file changed.

@github-actions github-actions / checkstyle

[checkstyle] src/arcade/potts/agent/cell/PottsCellFlyStem.java#L89 <com.puppycrawl.tools.checkstyle.checks.javadoc.MissingJavadocMethodCheck>

Missing a Javadoc comment.
Raw output
/github/workspace/./src/arcade/potts/agent/cell/PottsCellFlyStem.java:89:5: error: Missing a Javadoc comment. (com.puppycrawl.tools.checkstyle.checks.javadoc.MissingJavadocMethodCheck)

Check failure on line 110 in src/arcade/potts/agent/cell/PottsCellFlyStem.java

See this annotation in the file changed.

@github-actions github-actions / checkstyle

[checkstyle] src/arcade/potts/agent/cell/PottsCellFlyStem.java#L110 <LineLengthTest>

Line is longer than 120 characters (found 151).
Raw output
/github/workspace/./src/arcade/potts/agent/cell/PottsCellFlyStem.java:110:0: error: Line is longer than 120 characters (found 151). (LineLengthTest)

Check failure on line 113 in src/arcade/potts/agent/cell/PottsCellFlyStem.java

See this annotation in the file changed.

@github-actions github-actions / checkstyle

[checkstyle] src/arcade/potts/agent/cell/PottsCellFlyStem.java#L113 <com.puppycrawl.tools.checkstyle.checks.design.DesignForExtensionCheck>

Class 'PottsCellFlyStem' looks like designed for extension (can be subclassed), but the method 'make' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'PottsCellFlyStem' final or making the method 'make' static/final/abstract/empty, or adding allowed annotation for the method.
Raw output
/github/workspace/./src/arcade/potts/agent/cell/PottsCellFlyStem.java:113:5: error: Class 'PottsCellFlyStem' looks like designed for extension (can be subclassed), but the method 'make' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'PottsCellFlyStem' final or making the method 'make' static/final/abstract/empty, or adding allowed annotation for the method. (com.puppycrawl.tools.checkstyle.checks.design.DesignForExtensionCheck)

Check failure on line 113 in src/arcade/potts/agent/cell/PottsCellFlyStem.java

See this annotation in the file changed.

@github-actions github-actions / checkstyle

[checkstyle] src/arcade/potts/agent/cell/PottsCellFlyStem.java#L113 <com.puppycrawl.tools.checkstyle.checks.javadoc.MissingJavadocMethodCheck>

Missing a Javadoc comment.
Raw output
/github/workspace/./src/arcade/potts/agent/cell/PottsCellFlyStem.java:113:5: error: Missing a Javadoc comment. (com.puppycrawl.tools.checkstyle.checks.javadoc.MissingJavadocMethodCheck)

Check failure on line 33 in src/arcade/potts/agent/module/PottsModuleFlyStemProliferation.java

See this annotation in the file changed.

@github-actions github-actions / checkstyle

[checkstyle] src/arcade/potts/agent/module/PottsModuleFlyStemProliferation.java#L33 <com.puppycrawl.tools.checkstyle.checks.javadoc.MissingJavadocTypeCheck>

Missing a Javadoc comment.
Raw output
/github/workspace/./src/arcade/potts/agent/module/PottsModuleFlyStemProliferation.java:33:1: error: Missing a Javadoc comment. (com.puppycrawl.tools.checkstyle.checks.javadoc.MissingJavadocTypeCheck)

Check failure on line 68 in src/arcade/potts/agent/module/PottsModuleFlyStemProliferation.java

See this annotation in the file changed.

@github-actions github-actions / checkstyle

[checkstyle] src/arcade/potts/agent/module/PottsModuleFlyStemProliferation.java#L68 <com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocVariableCheck>

Missing a Javadoc comment.
Raw output
/github/workspace/./src/arcade/potts/agent/module/PottsModuleFlyStemProliferation.java:68:5: error: Missing a Javadoc comment. (com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocVariableCheck)

Check failure on line 91 in src/arcade/potts/agent/module/PottsModuleFlyStemProliferation.java

See this annotation in the file changed.

@github-actions github-actions / checkstyle

[checkstyle] src/arcade/potts/agent/module/PottsModuleFlyStemProliferation.java#L91 <com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocVariableCheck>

Missing a Javadoc comment.
Raw output
/github/workspace/./src/arcade/potts/agent/module/PottsModuleFlyStemProliferation.java:91:5: error: Missing a Javadoc comment. (com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocVariableCheck)

Check failure on line 93 in src/arcade/potts/agent/module/PottsModuleFlyStemProliferation.java

See this annotation in the file changed.

@github-actions github-actions / checkstyle

[checkstyle] src/arcade/potts/agent/module/PottsModuleFlyStemProliferation.java#L93 <com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocVariableCheck>

Missing a Javadoc comment.
Raw output
/github/workspace/./src/arcade/potts/agent/module/PottsModuleFlyStemProliferation.java:93:5: error: Missing a Javadoc comment. (com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocVariableCheck)

Check failure on line 103 in src/arcade/potts/agent/module/PottsModuleFlyStemProliferation.java

See this annotation in the file changed.

@github-actions github-actions / checkstyle

[checkstyle] src/arcade/potts/agent/module/PottsModuleFlyStemProliferation.java#L103 <com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocVariableCheck>

Missing a Javadoc comment.
Raw output
/github/workspace/./src/arcade/potts/agent/module/PottsModuleFlyStemProliferation.java:103:5: error: Missing a Javadoc comment. (com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocVariableCheck)

Check failure on line 202 in src/arcade/potts/agent/module/PottsModuleFlyStemProliferation.java

See this annotation in the file changed.

@github-actions github-actions / checkstyle

[checkstyle] src/arcade/potts/agent/module/PottsModuleFlyStemProliferation.java#L202 <com.puppycrawl.tools.checkstyle.checks.coding.SimplifyBooleanExpressionCheck>

Expression can be simplified.
Raw output
/github/workspace/./src/arcade/potts/agent/module/PottsModuleFlyStemProliferation.java:202:37: error: Expression can be simplified. (com.puppycrawl.tools.checkstyle.checks.coding.SimplifyBooleanExpressionCheck)

Check failure on line 204 in src/arcade/potts/agent/module/PottsModuleFlyStemProliferation.java

See this annotation in the file changed.

@github-actions github-actions / checkstyle

[checkstyle] src/arcade/potts/agent/module/PottsModuleFlyStemProliferation.java#L204 <com.puppycrawl.tools.checkstyle.checks.coding.SimplifyBooleanExpressionCheck>

Expression can be simplified.
Raw output
/github/workspace/./src/arcade/potts/agent/module/PottsModuleFlyStemProliferation.java:204:54: error: Expression can be simplified. (com.puppycrawl.tools.checkstyle.checks.coding.SimplifyBooleanExpressionCheck)

Check failure on line 211 in src/arcade/potts/agent/module/PottsModuleFlyStemProliferation.java

See this annotation in the file changed.

@github-actions github-actions / checkstyle

[checkstyle] src/arcade/potts/agent/module/PottsModuleFlyStemProliferation.java#L211 <com.puppycrawl.tools.checkstyle.checks.design.DesignForExtensionCheck>

Class 'PottsModuleFlyStemProliferation' looks like designed for extension (can be subclassed), but the method 'updateVolumeBasedGrowthRate' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'PottsModuleFlyStemProliferation' final or making the method 'updateVolumeBasedGrowthRate' static/final/abstract/empty, or adding allowed annotation for the method.
Raw output
/github/workspace/./src/arcade/potts/agent/module/PottsModuleFlyStemProliferation.java:211:5: error: Class 'PottsModuleFlyStemProliferation' looks like designed for extension (can be subclassed), but the method 'updateVolumeBasedGrowthRate' does not have javadoc that explains how to do that safely. If class is not designed for extension consider making the class 'PottsModuleFlyStemProliferation' final or making the method 'updateVolumeBasedGrowthRate' static/final/abstract/empty, or adding allowed annotation for the method. (com.puppycrawl.tools.checkstyle.checks.design.DesignForExtensionCheck)