Skip to content

Issue #565: Warn if updating a SKU to one that already exists in stock table. #572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bugfolder merged 1 commit into from
Jan 5, 2026
Merged

Issue #565: Warn if updating a SKU to one that already exists in stock table. #572

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
67 changes: 55 additions & 12 deletions uc_stock/uc_stock.module
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,17 +127,32 @@ function uc_stock_entity_delete($entity, $type) {

/**
* Implements hook_entity_update().
*
* Update the stock table if the model number has changed and there is not
* already an entry for this model number in the table (perhaps due to a
* different product having the same model number, which is allowed in
* Ubercart).
*/
function uc_stock_entity_update($entity, $type) {
if ($type == 'node' && in_array($entity->type, uc_product_types())) {
$old_model = $entity->original->model;
$new_model = $entity->model;
if($old_model != $new_model) {
db_update('uc_product_stock')
->fields(array('sku' => $new_model))
->condition('sku', $old_model)
->execute();
backdrop_set_message(t('Stock table updated: changed SKU @old_model to @new_model.', array('%title' => $entity->title, '@old_model' => $old_model, '@new_model' => $new_model)));
$products = uc_stock_tracked_products($new_model);
if (empty($products)) {
db_update('uc_product_stock')
->fields(array('sku' => $new_model))
->condition('sku', $old_model)
->execute();
backdrop_set_message(t('Stock table updated: changed SKU @old_model to @new_model.', array('%title' => $entity->title, '@old_model' => $old_model, '@new_model' => $new_model)));
}
else {
$listing = array();
foreach ($products as $nid => $title) {
$listing[] = l($title, 'node/' . $nid);
}
backdrop_set_message(t('SKU @new_model is already in the stock table for these products:', array('@new_model' => $new_model)) . theme('item_list', array('items' => $listing)), 'warning');
}
}
}
}
Expand All @@ -148,6 +163,8 @@ function uc_stock_entity_update($entity, $type) {
* Save a copy of the original form values and insert our own submission
* function for product adjustments so we can update stock when model is changed
* for an attribute.
*
* @see uc_product_adjustments_form()
*/
function uc_stock_form_uc_product_adjustments_form_alter(&$form, &$form_state, $form_id) {
$form['original_body'] = array(
Expand All @@ -160,7 +177,10 @@ function uc_stock_form_uc_product_adjustments_form_alter(&$form, &$form_state, $
/**
* Submission function for uc_product_adjustments_form().
*
* Update the stock table if the model number has changed for the variant.
* Update the stock table if the model number has changed for the variant and
* there is not already an entry for this model number in the table (perhaps due
* to a different product having the same model number, which is allowed in
* Ubercart).
*
* @see uc_product_adjustments_form_submit()
*/
Expand All @@ -170,11 +190,21 @@ function uc_stock_form_uc_product_adjustments_form_submit($form, &$form_state) {
$old_model = !empty($form_state['values']['original_body'][$key]['model']) ? $form_state['values']['original_body'][$key]['model']['#default_value'] : '';
$new_model = !empty($value['model']) ? $value['model'] : '';
if ($old_model != $new_model) {
db_update('uc_product_stock')
->fields(array('sku' => $new_model))
->condition('sku', $old_model)
->execute();
backdrop_set_message(t('Stock table updated: changed sku @old_model to @new_model', array('@old_model' => $old_model, '@new_model' => $new_model)));
$products = uc_stock_tracked_products($new_model);
if (empty($products)) {
db_update('uc_product_stock')
->fields(array('sku' => $new_model))
->condition('sku', $old_model)
->execute();
backdrop_set_message(t('Stock table updated: changed SKU @old_model to @new_model', array('@old_model' => $old_model, '@new_model' => $new_model)));
}
else {
$listing = array();
foreach ($products as $nid => $title) {
$listing[] = l($title, 'node/' . $nid);
}
backdrop_set_message(t('SKU @new_model is already in the stock table for these products:', array('@new_model' => $new_model)) . theme('item_list', array('items' => $listing)), 'warning');
}
}
}
}
Expand Down Expand Up @@ -250,7 +280,20 @@ function uc_stock_level($sku) {
* Boolean indicating whether or not the sku has an active stock record.
*/
function uc_stock_is_active($sku) {
return (bool) db_query("SELECT active FROM {uc_product_stock} WHERE sku = :sku", array(':sku' => $sku))->fetchField();
return (bool) db_query('SELECT active FROM {uc_product_stock} WHERE sku = :sku', array(':sku' => $sku))->fetchField();
}

/**
* Returns a list of all product titles in the stock table for a given SKU
* keyed on their nids.
*/
function uc_stock_tracked_products($sku) {
return db_query('
SELECT DISTINCT s.nid, n.title
FROM {uc_product_stock} s
LEFT JOIN {node} n ON n.nid = s.nid
WHERE s.sku = :sku', array(':sku' => $sku))
->fetchAllKeyed();
}

/**
Expand Down