Skip to content

Issue #486: Improve quantity validation message for required whole numbers #563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bugfolder merged 1 commit into from
Dec 13, 2025
Merged

Issue #486: Improve quantity validation message for required whole numbers #563

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions uc_product/tests/uc_product.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,10 +169,10 @@ class UbercartProductTestCase extends UbercartTestHelper {

// Check invalid quantity messages.
$this->backdropPost('node/' . $this->product->nid, array('qty' => 'x'), 'Add to cart');
$this->assertText('The quantity must be an integer.');
$this->assertText('The quantity must be zero or a positive whole number.');

$this->backdropPost('node/' . $this->product->nid, array('qty' => '1a'), 'Add to cart');
$this->assertText('The quantity must be an integer.');
$this->assertText('The quantity must be zero or a positive whole number.');

// Check cart add message.
$this->backdropPost('node/' . $this->product->nid, array('qty' => '1'), 'Add to cart');
Expand Down
2 changes: 1 addition & 1 deletion uc_store/uc_store.module
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -565,7 +565,7 @@ function uc_store_validate_number(&$element, &$form_state) {
*/
function uc_store_validate_uc_quantity(&$element, &$form_state) {
if (!preg_match('/^\d+$/', $element['#value'])) {
form_error($element, t('The quantity must be an integer.'));
form_error($element, t('The quantity must be zero or a positive whole number.'));
}
elseif (empty($element['#allow_zero']) && !$element['#value']) {
form_error($element, t('The quantity cannot be zero.'));
Expand Down