Fixing some warnings

babisque · Jun 5, 2024 · 231f2a3 · 231f2a3
1 parent 5681a5e
commit 231f2a3
Show file tree

Hide file tree

Showing 6 changed files with 6 additions and 11 deletions.
diff --git a/Catalog/Catalog.Core/DTO/Category/CategoryGetRes.cs b/Catalog/Catalog.Core/DTO/Category/CategoryGetRes.cs
@@ -3,5 +3,5 @@ namespace Catalog.Core.DTO.Category;
 public class CategoryGetRes
 {
     public int Id { get; set; }
-    public string Name { get; set; }
+    public required string? Name { get; set; }
 }
diff --git a/Catalog/Catalog.Core/DTO/Category/CategoryUpdateReq.cs b/Catalog/Catalog.Core/DTO/Category/CategoryUpdateReq.cs
@@ -2,5 +2,5 @@ namespace Catalog.Core.DTO.Category;
 
 public class CategoryUpdateReq
 {
-    public string Name { get; set; }
+    public required string? Name { get; set; }
 }
diff --git a/Catalog/Catalog.Core/DTO/Product/ProductPostReq.cs b/Catalog/Catalog.Core/DTO/Product/ProductPostReq.cs
@@ -5,6 +5,6 @@ public class ProductPostReq
     public string? Name { get; set; }
     public string? Description { get; set; }
     public decimal Price { get; set; }
-    public List<int> Categories { get; set; }
+    public List<int> Categories { get; set; } = [];
     public int Stock { get; set; }
 }
diff --git a/Catalog/Catalog.Core/DTO/Product/ProductUpdateReq.cs b/Catalog/Catalog.Core/DTO/Product/ProductUpdateReq.cs
@@ -5,6 +5,6 @@ public class ProductUpdateReq
     public string? Name { get; set; }
     public string? Description { get; set; }
     public decimal? Price { get; set; }
-    public List<Entities.Category> Categories { get; set; }
+    public List<Entities.Category> Categories { get; set; } = [];
     public int? Stock { get; set; }
 }
diff --git a/Catalog/Catalog.Core/Entities/Category.cs b/Catalog/Catalog.Core/Entities/Category.cs
@@ -4,7 +4,6 @@ namespace Catalog.Core.Entities;
 
 public class Category : EntityBase
 {
-    public string Name { get; set; }
-    [JsonIgnore]
-    public List<Product> Products { get; set; }
+    public string? Name { get; set; }
+    [JsonIgnore] public List<Product> Products { get; set; } = [];
 }
diff --git a/Catalog/Catalog.Test/CategoryControllerTests.cs b/Catalog/Catalog.Test/CategoryControllerTests.cs
@@ -164,10 +164,6 @@ public async void Delete_NonExistingId_ReturnsNotFount()
     {
         // Arrange
         var category = new Category();
-        var categoryReq = new CategoryUpdateReq
-        {
-            Name = "Category"
-        };
 
         _categoryRepositoryMock.Setup(repo => repo.GetByIdAsync(1))
             .ReturnsAsync(category);