Prevent duplication while ejecting stage presets #80
Conversation
aulisius
changed the title
src/upgradeConfig.js
Outdated
| @@ -61,14 +61,15 @@ function changePresets(config, options = {}) { | |||
| } | |||
|
|
|||
| if (newPlugins.length > 0) { | |||
| config.plugins = (config.plugins || []).concat(...newPlugins); | |||
| config.plugins = (config.plugins || []); | |||
There was a problem hiding this comment.
Since we are not concating here anymore, this if statement should be moved where we actually need to guard against config.plugins from being undefined.
src/upgradeConfig.js
Outdated
|
|
||
| if (config.env) { | ||
| Object.keys(config.env).forEach((env) => { | ||
| changePresets(config.env[env]); | ||
| changePlugins(config.env[env]); | ||
| let updatedPlugins = changePresets(config.env[env]); |
There was a problem hiding this comment.
newPlugins instead of updatedPlugins, since we didn't update the plugins list yet?
|
PR fixes done! :D |
|
can we get this merged @nicolo-ribaudo @existentialism ? |
|
Does this work with plugins ejected from the stage presets which have options? e.g. {
"plugins": [
"@babel/plugin-proposal-decorators"
],
"presets": [
"stage-2"
]
} |
|
This is the output that is generated. @nicolo-ribaudo Can you verify if this is the expected output? If this is what we want, will add a test for the same. Object {
"plugins": Array [
Array [
"@babel/plugin-proposal-decorators",
Object {
"legacy": true,
},
],
"@babel/plugin-syntax-dynamic-import",
"@babel/plugin-syntax-import-meta",
"@babel/plugin-proposal-class-properties",
"@babel/plugin-proposal-json-strings",
Array [
"@babel/plugin-proposal-decorators",
Object {
"legacy": true,
},
],
"@babel/plugin-proposal-function-sent",
"@babel/plugin-proposal-export-namespace-from",
"@babel/plugin-proposal-numeric-separator",
"@babel/plugin-proposal-throw-expressions",
],
"presets": Array [],
};Edit: Just noticed that the output is wrong. Will fix that. |
|
Closing this in favor of #100 which is a better solution than mine. |
This is towards closing #77
For the time being, have added the failing test case.