Open
Conversation
The Bar was off by a couple pixels and it gets worse with more BarCount, this fixes this. Was attempting to take into account modded Bars, snapping this bar onto those so this always ends up being the left most. Was not able to yet make an automatic generic fits all so I left out that work, but was able to add detection for "Magic Stardew" as that was my focus. I would change the name for "otherBarWidth" to something else like Padding. (This is the only use of it on this file) I would test this before adding it officially just encase.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Bar was off by a couple pixels and it gets worse with more BarCount, this fixes this.
Was attempting to take into account modded Bars, snapping this bar onto those so this always ends up being the left most. I did add on my end detection for "Magic Stardew" as that was my focus, but was not able to yet make an automatic generic fits all so I left out that work, maybe in another PR but no promises.
I would change the name for "otherBarWidth" to something else like Padding. (This is the only use of it on this file)
I would test this before adding it officially just encase.