Skip to content

add enabled hook lists for performance improvement #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
55Honey merged 1 commit into from
Feb 21, 2025
Merged

add enabled hook lists for performance improvement #19

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions src/ArenaReplay.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,9 @@ std::unordered_map<uint32, BgPlayersGuids> bgPlayersGuids;
class ArenaReplayServerScript : public ServerScript
{
public:
ArenaReplayServerScript() : ServerScript("ArenaReplayServerScript") {}
ArenaReplayServerScript() : ServerScript("ArenaReplayServerScript", {
SERVERHOOK_CAN_PACKET_SEND
}) {}

bool CanPacketSend(WorldSession* session, WorldPacket& packet) override
{
Expand Down Expand Up @@ -155,7 +157,9 @@ class ArenaReplayServerScript : public ServerScript

class ArenaReplayArenaScript : public ArenaScript {
public:
ArenaReplayArenaScript() : ArenaScript("ArenaReplayArenaScript") {}
ArenaReplayArenaScript() : ArenaScript("ArenaReplayArenaScript", {
ARENAHOOK_ON_BEFORE_CHECK_WIN_CONDITION
}) {}

bool OnBeforeArenaCheckWinConditions(Battleground *const bg) override {
const bool isReplay = bgReplayIds.find(bg->GetInstanceID()) != bgReplayIds.end();
Expand Down Expand Up @@ -204,7 +208,11 @@ class ArenaReplayArenaScript : public ArenaScript {
class ArenaReplayBGScript : public BGScript
{
public:
ArenaReplayBGScript() : BGScript("ArenaReplayBGScript") {}
ArenaReplayBGScript() : BGScript("ArenaReplayBGScript", {
ALLBATTLEGROUNDHOOK_ON_BATTLEGROUND_UPDATE,
ALLBATTLEGROUNDHOOK_ON_BATTLEGROUND_ADD_PLAYER,
ALLBATTLEGROUNDHOOK_ON_BATTLEGROUND_END
}) {}

void OnBattlegroundUpdate(Battleground* bg, uint32 /* diff */) override
{
Expand Down Expand Up @@ -1162,7 +1170,9 @@ class ReplayGossip : public CreatureScript
class ConfigLoaderArenaReplay : public WorldScript
{
public:
ConfigLoaderArenaReplay() : WorldScript("config_loader_arena_replay") {}
ConfigLoaderArenaReplay() : WorldScript("config_loader_arena_replay", {
WORLDHOOK_ON_AFTER_CONFIG_LOAD
}) {}
virtual void OnAfterConfigLoad(bool /*Reload*/) override {
DeleteOldReplays();
}
Expand Down