Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qt: Add diagonal directional input presets for circlepad and c-stick #404

Merged
merged 6 commits into from
Oct 29, 2024

Conversation

kleidis
Copy link
Contributor

@kleidis kleidis commented Aug 31, 2024

Closes #388

This adds new buttons to configure_input for diagonal direction presets (i.e. upright , downleft and so on) for both the circlepad and c-stick

Preferably should be used for single state keys but also works with game pad analog sticks

Screenshot

@BlurrySquire BlurrySquire self-requested a review August 31, 2024 14:10
Copy link
Contributor

@BlurrySquire BlurrySquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine in Luigi's Mansion 2 and Super Mario 3D Land. Unfortunately I don't have a game that uses the c-stick so I was unable to test the c-stick. Considering that the implementation is the same it should work correctly.

@kleidis
Copy link
Contributor Author

kleidis commented Aug 31, 2024

Works fine in Luigi's Mansion 2 and Super Mario 3D Land. Unfortunately I don't have a game that uses the c-stick so I was unable to test the c-stick. Considering that the implementation is the same it should work correctly.

You can test with a 3ds input tester homebrew
That's what i did, and it worked on my end

@BlurrySquire
Copy link
Contributor

You can test with a 3ds input tester homebrew That's what i did, and it worked on my end

Forgot that those existed, but it is confirmed to work on more than one machine which is good.

@kleidis
Copy link
Contributor Author

kleidis commented Sep 13, 2024

Removed some useless code and rebased, IDK why license CI is failing on config.h tho

src/lime_qt/configuration/config.cpp Outdated Show resolved Hide resolved
Copy link
Member

@OpenSauce04 OpenSauce04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks fine to me. Functionality works as expected.

@OpenSauce04 OpenSauce04 merged commit 21aec70 into azahar-emu:master Oct 29, 2024
12 checks passed
@kleidis kleidis deleted the fein branch October 29, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request size/XL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Diagonal directional buttons
3 participants