Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed secondary window hotkeys not working after applying settings #288

Merged

Conversation

OpenSauce04
Copy link
Member

@OpenSauce04 OpenSauce04 commented Jul 13, 2024

Closes #277

The code being added here is a little questionable, but at some point I want to come back and rewrite the overall hotkey initialization function it because it wasn't great even before I changed anything. This should be fine for now.

@OpenSauce04 OpenSauce04 added the bug Something isn't working label Jul 13, 2024
@OpenSauce04 OpenSauce04 added this to the 2116 milestone Jul 13, 2024
@OpenSauce04 OpenSauce04 force-pushed the fix-secondary-window-hotkeys branch from 8f606e1 to df89e8d Compare July 13, 2024 16:34
Copy link

@imnotpolar imnotpolar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

testing both, 2115 and this commit builds i can say it works as intended, about the code, considering you plan on coming back to it later down the line, it looks good for me

@BlurrySquire
Copy link
Contributor

BlurrySquire commented Jul 13, 2024

If you still need a tester I can test tomorrow. I can test linux and windows. Sorry, I didn't get round to reviewing today, something came up.

@OpenSauce04 OpenSauce04 removed the request for review from BlurrySquire July 13, 2024 23:15
@OpenSauce04 OpenSauce04 merged commit bc1cd10 into azahar-emu:master Jul 13, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changing settings prevents secondary window from being fullscreened when using Separate Windows layout
3 participants