Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aya: add a safe wrapper for 'BPF_TASK_FD_QUERY' logic #492

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

aya: add a safe wrapper for 'BPF_TASK_FD_QUERY' logic #492

wants to merge 1 commit into from

Conversation

lucab
Copy link

@lucab lucab commented Jan 17, 2023 •
edited by tamird
Loading

This add bindings for the bpf_task_fd_type FFI type, and then add a safe wrapper for the BPF_TASK_FD_QUERY logic.

This change is Reviewable

@netlify
Copy link

netlify bot commented Jan 17, 2023 •
edited
Loading

✅ Deploy Preview for aya-rs-docs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit ff282d6
🔍 Latest deploy log https://app.netlify.com/sites/aya-rs-docs/deploys/67c8bac280b65f0008c1ea64
😎 Deploy Preview https://deploy-preview-492--aya-rs-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@lucab
Copy link
Author

lucab commented Jan 17, 2023

CI is failing because of #490.

@lucab lucab force-pushed the ups/query-task-fd branch from 587d04a to 8ded21e Compare January 25, 2023 10:18
@lucab
Copy link
Author

lucab commented Jan 25, 2023

Rebased on main, CI is now green.

@alessandrod alessandrod self-requested a review January 26, 2023 11:20
@dave-tucker dave-tucker added aya This is about aya (userspace) api/needs-review Makes an API change that needs review feature A PR that implements a new feature or enhancement labels Feb 23, 2023
@mergify mergify bot added aya-obj Relating to the aya-obj crate test A PR that improves test cases or CI labels Sep 14, 2023
@mergify
Copy link

mergify bot commented Sep 14, 2023

@lucab, this pull request is now in conflict and requires a rebase.

@mergify mergify bot added the needs-rebase label Sep 14, 2023
@mergify Mergify
Copy link

mergify bot commented Feb 6, 2024

@lucab, this pull request is now in conflict and requires a rebase.

@mergify mergify bot removed the needs-rebase label Jan 1, 2025
@mergify Mergify
Copy link

mergify bot commented Jan 1, 2025

@lucab, this pull request is now in conflict and requires a rebase.

@mergify mergify bot added the needs-rebase label Jan 1, 2025
@lucab @tamird
aya: add a safe wrapper for 'BPF_TASK_FD_QUERY'
ff282d6 
This wraps the logic for `BPF_TASK_FD_QUERY` in a safe helper.
@tamird tamird force-pushed the ups/query-task-fd branch from 8ded21e to ff282d6 Compare March 5, 2025 20:57
@mergify mergify bot removed the needs-rebase label Mar 5, 2025
tamird
tamird requested changes Mar 5, 2025
View reviewed changes
Copy link
Member

@tamird tamird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lucab I have rebased this and made sure clippy passes. The codegen changes were no longer needed. However, this needs a test.

@tamird tamird requested a review from dave-tucker March 5, 2025 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tamird tamird tamird requested changes

@alessandrod alessandrod Awaiting requested review from alessandrod

@dave-tucker dave-tucker Awaiting requested review from dave-tucker

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
api/needs-review Makes an API change that needs review aya This is about aya (userspace) aya-obj Relating to the aya-obj crate feature A PR that implements a new feature or enhancement needs tests test A PR that improves test cases or CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lucab @tamird @dave-tucker