Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Appease clippy #1122

Merged
merged 2 commits into from
Dec 27, 2024
Merged

Appease clippy #1122

merged 2 commits into from
Dec 27, 2024

Conversation

tamird
Copy link
Member

@tamird tamird commented Dec 27, 2024

This change is Reviewable

Copy link

netlify bot commented Dec 27, 2024

Deploy Preview for aya-rs-docs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 9ec2d31
🔍 Latest deploy log https://app.netlify.com/sites/aya-rs-docs/deploys/676eb58a3371d40008893e80
😎 Deploy Preview https://deploy-preview-1122--aya-rs-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mergify mergify bot added aya This is about aya (userspace) aya-bpf This is about aya-bpf (kernel) aya-obj Relating to the aya-obj crate labels Dec 27, 2024
@vadorovsky
Copy link
Member

Oh, sorry, I already merged #1121

That said, I like your aya-log fix, I will stamp after a rebase

@tamird
Copy link
Member Author

tamird commented Dec 27, 2024

Merged without review? Let's not do that, please. Even the title has a typo.

@vadorovsky
Copy link
Member

Fine, I will ping for review next time. That said, there were many other "Appease clippy" PRs which were merged without review as well.

@tamird
Copy link
Member Author

tamird commented Dec 27, 2024

Reviewed:
#1046
#1040
#1016
#969
#952
#933

Not reviewed:
#922 (merged 16 hours after last update)
#911 (merged right away)

You're right that there's some precedent, but in the majority of cases, I wait for review.

@vadorovsky
Copy link
Member

vadorovsky commented Dec 27, 2024

Alright, sorry then. I will make sure to always ping you.

@tamird tamird merged commit 41706d7 into aya-rs:main Dec 27, 2024
27 checks passed
@tamird tamird deleted the appease-clippy branch December 27, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aya This is about aya (userspace) aya-bpf This is about aya-bpf (kernel) aya-obj Relating to the aya-obj crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants