-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebuild axosyslog image with auto patch version increment #411
base: main
Are you sure you want to change the base?
Conversation
2762970
to
c6c4a45
Compare
I would like to provide a test job run (from my fork) here (AxoSyslog stable image), but until now it fails every time on image build. update: |
c6c4a45
to
ab1ede8
Compare
9ec7b0c
to
ff36c55
Compare
- this is for automatically update python libraries Signed-off-by: Andras Mitzki <[email protected]>
b78243d
to
4391192
Compare
The PR is ready for the review.
for example:
for example:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This must have been really difficult to test properly, thank you for going through everything.
- after this change next docker tag will automatically calculated in a following way: - if actual git tag version is greater than previous docker tag example: current git tag: 4.10.0 last docker tag: 4.9.0-2 next docker tag: 4.10.0-1 - if actual git tag version is equals with previous docker tag example: current git tag: 4.9.0 last docker tag: 4.9.0-2 next docker tag: 4.9.0-3 - if actual git tag version is less than previous docker tag, than compare script will display a warning and will exit Signed-off-by: Andras Mitzki <[email protected]>
4391192
to
3220ae0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. LGTM.
I think we need to test 3 scenarios and we can merge it:
axosyslog-nightly.yml
should produce a nightly without problems4.99.0
release should produce an image with tags4.99.0-1, 4.99.0, latest
- triggering a rebuild on
4.9.0
should bump the rebuild version:4.9.0-3, 4.9.0, latest
After this PR when we request a new stable image job the axosyslog patch version will increment automatically