Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: notifications don't render correctly #502

Open
wants to merge 31 commits into
base: env/devnet-amplifier
Choose a base branch
from

Conversation

npty
Copy link
Member

@npty npty commented Feb 11, 2025

Description

This PR fixes a lot of issues related to notifications don't render correctly after the token deployment. The bonus changes are supporting devnet-amplifier to various packages in the sdk.

Changes

  • Fix the loading status never change in notification
  • Fix the notification doesn't support multiple destination chains due to we pass deploymentMessageId as the tx hash.
  • Fix the invalid axelarscan link in notification (tx_hash:log_index -> tx_hash-log_index)
  • Fix the notification is not dismiss-able.
  • Enhanced transaction tracking to correctly handle two-hop transactions by showing status details for both Axelar (intermediary chain) and the final destination chain.
  • Support devnet-amplifier in multiple axelarjs packages (see changeset file).

Screenshots

image

@npty npty self-assigned this Feb 11, 2025
Copy link

changeset-bot bot commented Feb 11, 2025

🦋 Changeset detected

Latest commit: 5033cd3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@axelarjs/transaction-recovery Patch
@axelarjs/cosmos Patch
@axelarjs/core Patch
@axelarjs/api Patch
@axelarjs/evm Patch
@axelarjs/maestro Patch
@axelarjs/deposit-address Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Feb 11, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
axelar-maestro ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 13, 2025 10:50am
axelar-registry ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 13, 2025 10:50am
axelar-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 13, 2025 10:50am
axelarjs-maestro-devnet-amplifier ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 13, 2025 10:50am

@npty npty force-pushed the chore/fix-notification branch from 1769c79 to 9918aac Compare February 11, 2025 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants