feat: add xrpl-evm-devnet #553
Conversation
| "tokenSymbol": "XRP", | ||
| "confirmations": 1, | ||
| "finality": "finalized", | ||
| "approxFinalityWaitTime": 1, |
There was a problem hiding this comment.
@AdriaCarrera any docs on finality mechanism I can review?
| "name": "Blockscout", | ||
| "url": "https://explorer.xrplevm.org", | ||
| "api": "https://explorer.xrplevm.org/api", | ||
| "apiKey": "empty" |
There was a problem hiding this comment.
You can remove "apiKey": "empty" from the config.
| "address": "0x6850335DA5b6E960eB509B7ec4D159ebA8e89eFd", | ||
| "implementation": "0x35dE9395c6eC7F12dbb21f9947E24C3592b85A7F", | ||
| "implementationCodehash": "0x70edf88fd63576602e293de1d994e77541daf1a885e97800d9b6c94d7d8482ab", | ||
| "deploymentMethod": "create3", |
There was a problem hiding this comment.
Deployment method for AxelarGateway should be create2.
| "deploymentMethod": "create3", | ||
| "previousSignersRetention": 15, | ||
| "domainSeparator": "0x8a1a34e4e527215bb55d1fa7996fafae63ca752ca9224cd7c0249b11b33554ff", | ||
| "minimumRotationDelay": 86400, |
There was a problem hiding this comment.
minimumRotationDelay on devnet should be 0.
| "minimumRotationDelay": 86400, | ||
| "connectionType": "amplifier", | ||
| "owner": "0x9159C650e1D7E10a17c450eb3D50778aBA593D61", | ||
| "salt": "xrpl-evm-devnet" |
There was a problem hiding this comment.
It should be the release tag of AxelarGateway used, something like: v6.0.4
| "owner": "0x9159C650e1D7E10a17c450eb3D50778aBA593D61", | ||
| "address": "0x217D3F23884beD1B13177DaC309634E4A30fe5F1", | ||
| "deployer": "0x9159C650e1D7E10a17c450eb3D50778aBA593D61", | ||
| "deploymentMethod": "create3", |
| }, | ||
| "InterchainTokenFactory": { | ||
| "deployer": "0x9159C650e1D7E10a17c450eb3D50778aBA593D61", | ||
| "salt": "ITS Factory xrpl-evm-devnet devnet-amplifier v0", |
There was a problem hiding this comment.
I see salts included in the contract deployments where they are not present for other amplifier chains like flow, as well as the salt is different from the defaults. would like to discuss the reasoning behind it.
| "1", | ||
| "1" |
There was a problem hiding this comment.
The value is 6/10 for devnet-amplifier.
| "1", | ||
| "1" |
| @@ -1089,6 +1198,21 @@ | |||
| "domainSeparator": "0x293407cef6cb084c2c7ca31794d4cc95d8c3ea2aced086aebb518a2c37b28dc6", | |||
| "address": "axelar1uuja08qdy790ewq9mz0r6t7c4yp9fqccu9f9zssr4tu4k0l52yeqjhckm3" | |||
| }, | |||
| "xrpl-evm-devnet": { | |||
| "governanceAddress": "axelar1zlr7e5qf3sz7yf890rkh9tcnu87234k6k7ytd9", | |||
| "adminAddress": "axelar1hxcz4z263uxvlsmrj2pzfhmy8ggwwqjwu58w4t", | |||
There was a problem hiding this comment.
axelar1zlr7e5qf3sz7yf890rkh9tcnu87234k6k7ytd9 is used as the admin address on devnet-amplifier.
No description provided.